296573 - FF11a1 crash [@ nsBookmarksService::ClearBookmarksContainer]

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Jay Patel [:jay]]

This might be similar to bug 290943, but I wanted to log a new bug since most
people believe that other bug to be fixed.  It is a topcrasher for the Deer Park
Alpha 1 release:
http://talkback-public.mozilla.org/reports/firefox/FF11a1/FF11a1-topcrashers.html

There isn't much data to go on yet, but here is a link to the latest Firefox
Trunk Talkback data:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=nsBookmarksService::ClearBookmarksContainer&vendor=MozillaOrg&product=FirefoxTrunk&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid

And a recent incident:
Incident ID: 6327722
Stack Signature	nsDownloadsDataSource::GetURI 2f1aa7a1
Product ID	FirefoxTrunk
Build ID	2005053112
Trigger Time	2005-06-02 06:27:28.0
Platform	Win32
Operating System	Windows NT 5.1 build 2600
Module	firefox.exe + (003e9bd2)
URL visited	n/A
User Comments	Clicked the Security-Tab in the options Dialog, I installed Deer
Park just a minute ago.
Since Last Crash	44 sec
Total Uptime	44 sec
Trigger Reason	Access violation
Source File, Line No.
c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp,
line 1566
Stack Trace 	
nsDownloadsDataSource::GetURI 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp,
line 1566]
nsDownloadManager::~nsDownloadManager 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/toolkit/components/downloads/src/nsDownloadManager.cpp,
line 146]
nsComponentManagerImpl::GetService 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/xpcom/components/nsComponentManager.cpp,
line 2111]
nsJSCID::GetService 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcjsid.cpp,
line 899]
XPTC_InvokeByIndex 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 102]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2100]
XPC_WN_CallMethod 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1348]
js_Invoke 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1182]
js_Interpret 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 3473]
js_Invoke 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1202]
js_InternalInvoke 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1279]
js_InternalGetOrSet 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1322]
js_Interpret 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 3299]
js_Invoke 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/jsinterp.c, line 1202]
nsXPCWrappedJSClass::CallMethod 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1339]
nsXPCWrappedJS::CallMethod 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp,
line 450]
SharedStub 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp,
line 147]
nsXULDocument::ResumeWalk 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/content/xul/document/src/nsXULDocument.cpp,
line 3205]
nsXULDocument::OnStreamComplete 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/content/xul/document/src/nsXULDocument.cpp,
line 3451]
nsStreamLoader::OnStopRequest 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/netwerk/base/src/nsStreamLoader.cpp,
line 137]
nsJARChannel::OnStopRequest 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/modules/libjar/nsJARChannel.cpp,
line

Comment 1

[Jay Patel [:jay]]

Whoops!  Disregard the incident I posted before (it was meant for bug 280442). I
meant to post this:

Incident ID: 6348784
Stack Signature	nsBookmarksService::ClearBookmarksContainer 5b79f79c
Product ID	FirefoxTrunk
Build ID	2005053112
Trigger Time	2005-06-02 22:19:53.0
Platform	Win32
Operating System	Windows NT 5.0 build 2195
Module	firefox.exe + (0048d081)
URL visited	none
User Comments	Closing Deer Park
Since Last Crash	635 sec
Total Uptime	635 sec
Trigger Reason	Access violation
Source File, Line No.
c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp,
line 5623
Stack Trace 	
nsBookmarksService::ClearBookmarksContainer 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp,
line 5623]
nsFeedLoadListener::OnStopRequest 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/browser/components/bookmarks/src/nsBookmarksFeedHandler.cpp,
line 234]
nsStreamListenerTee::OnStopRequest 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/netwerk/base/src/nsStreamListenerTee.cpp,
line 65]
nsInputStreamPump::OnStateStop 
[c:/builds/tinderbox/Fx-Trunk/WINNT_5.2_Depend/mozilla/netwerk/base/src/nsInputStreamPump.cpp,
line 507]

Comment 2

[Bastiaan Jacques]

Attachment: fix

Taking.

The problem here is that the original author forgot to check the rv passed to
do_CreateInstance(). This patch does that and adds a small cosmetic cleanup.

Jay, did you forget to change the component of this bug?

Comment 3

[Bastiaan Jacques]

Requesting blocking1.8b3 for this very fixable topcrasher.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 186910 [details] [diff] [review]
fix

we don't want to assert, and someday crash (!) in this case.  If the failure is
valid and expected, don't use this macro.

Comment 5

[Bastiaan Jacques]

Attachment: address comments

This patch addresses comments mconner gave me on IRC.

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 187889 [details] [diff] [review]
address comments

let's try to get this in for a2, since its a topcrasher in a1

Comment 7

[Benjamin Smedberg]

Comment on attachment 187889 [details] [diff] [review]
address comments

a=bsmedberg for landing on 6/30 only

Comment 8

[Bastiaan Jacques]

Checked in by timeless (2005-06-30 18:38).