296582 - create-guided template refers to "zarro boogs" instead of terms.zeroSearchResults

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P4)

Description

[A. Karl Kornel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax)

The default template for bug/create/create-guided.html references the phrase
"Zarro Boogs" directly in the HTML.  However, there seems to be a pre-defined
variable (terms.zeroSearchResults in global/variables.none.tmpl) which defaults
to "Zarro Boogs".

Should the code in create-guided.html.tmpl have "Zarro Boogs" hard-coded in
HTML, or should it instead have "[% terms.zeroSearchResults %]"?

Reproducible: Always

Steps to Reproduce:

Comment 1

[A. Karl Kornel]

Attachment: Change "Zarro Boogs" to "terms.zeroSearchResults" (for CVS tip)

I hope this is actually correct (first time patching).	I modified
`create-guided.html.tmpl` from the current version in CVS to use "[%
terms.zeroSearchResults %]" instead of "Zarro Boogs".

Comment 2

[Vlad Dascalu]

Comment on attachment 185312 [details] [diff] [review]
Change "Zarro Boogs" to "terms.zeroSearchResults" (for CVS tip)

The line exceeds 72 / 80 chars, so probably the length is a little off and it
could be splitted into two lines, but it's pretty tricky with TT prechomping
anyway.

If we want to backport to 2.18, then the patch applies cleanly to it as well
(2.18 has this problem as well).

Comment 3

[Dave Miller [:justdave]]

sure

Comment 4

[Frédéric Buclin]

Comment on attachment 185312 [details] [diff] [review]
Change "Zarro Boogs" to "terms.zeroSearchResults" (for CVS tip)

This patch does not apply cleany on the branch.

Comment 5

[A. Karl Kornel]

Comment on attachment 185312 [details] [diff] [review]
Change "Zarro Boogs" to "terms.zeroSearchResults" (for CVS tip)

Absolutely correct.  Renamed patch to note it's for tip only.  2.18.1 patch
coming in <10 minutes.

Comment 6

[A. Karl Kornel]

Attachment: Change "Zarro Boogs" to "terms.zeroSearchResults" (patch on top of 2.18.1)

Version of attachment 185312 [details] [diff] [review], this time created by modifying a copy of
create-guided.html.tmpl pulled fresh of CVS (-rBugzilla_Stable).

As noted in comment 2, I kept the lines under 80 characters.

Comment 7

[Vlad Dascalu]

Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v
 <--  create-guided.html.tmpl
new revision: 1.18.2.2; previous revision: 1.18.2.1
done

Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v
 <--  create-guided.html.tmpl
new revision: 1.26; previous revision: 1.25
done