attempting to save a detached attachment opens it instead

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: ajschult784, Assigned: neil)

Tracking

(Blocks: 1 bug)

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
With linux suite trunk 20050603, if I detach an attachment and then attempt to
save it (using save as from the context menu), it "opens" the attachment
instead, either in a browser window, or with the
how-do-you-want-to-handle-this-file dialog.  It should just bring up the file
picker and let me save it.
(Assignee)

Comment 1

13 years ago
It looks as if we don't really have a way to save detached attachments
[Thunderbird also displays the helper dialog for both open and save]
unless perhaps we should hand off to saveURL? What would that involve?
saveURL basically only wants the URL (as a string, if I recall correctly). it
will then show a filepicker and save the URL.
(Assignee)

Comment 3

13 years ago
Created attachment 185362 [details] [diff] [review]
Possible patch

Comment 4

13 years ago
Comment on attachment 185362 [details] [diff] [review]
Possible patch

>Index: xpfe/communicator/resources/locale/en-US/contentAreaCommands.properties
>===================================================================
>+SaveAttachmentTtle=Save Attachment
SaveAttachmentTitle even?
(Reporter)

Comment 5

13 years ago
Comment on attachment 185362 [details] [diff] [review]
Possible patch

this patch works fine for me (with Ttle => Title)
(Assignee)

Comment 6

13 years ago
Created attachment 185384 [details] [diff] [review]
Proposed patch
Attachment #185362 - Attachment is obsolete: true
Attachment #185384 - Flags: superreview?(bienvenu)
Attachment #185384 - Flags: review?(mnyromyr)

Comment 7

13 years ago
Comment on attachment 185384 [details] [diff] [review]
Proposed patch

I'll take care of this for tbird
Attachment #185384 - Flags: superreview?(bienvenu) → superreview+

Comment 8

13 years ago
Comment on attachment 185384 [details] [diff] [review]
Proposed patch

I'm not quite happy with SaveAttachmentTitle being in
contentAreaCommands.properties, while messenger.properties contains the very
same as  SaveAttachment, but anyway...

While you're at it, you might want to kill the erroneous space before the
ellipsis in <!ENTITY detachAttachmentCmd.label	  "Detach ...">
(http://lxr.mozilla.org/mozilla/search?string=detach%20...) also. ;-)

Besides, we should probably have different icons in the attachment box for
deleted and detached attachments...
Attachment #185384 - Flags: review?(mnyromyr) → review+

Comment 9

13 years ago
(In reply to comment #8)
> Besides, we should probably have different icons in the attachment box for
> deleted and detached attachments...

Thunderbird already has the former, but missis the latter also: see bug 292385.
(Assignee)

Updated

13 years ago
Attachment #185384 - Flags: approval1.8b3?

Comment 10

13 years ago
Okay, deleted does work in Mozilla, too (my build was horked there).

Updated

13 years ago
Attachment #185384 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Comment 11

13 years ago
Patch checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core

Updated

9 years ago
Blocks: 537231
You need to log in before you can comment on or make changes to this bug.