296643 - Uninstalling themes in Safe Mode kills extensions

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[IU]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050603 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050603 Firefox/1.0+

If you uninstall a Firefox theme while in Safe Mode, firefox permanently
disables all extensions, and the extensions remain inactive and unusable when
running in normal operating mode.


Reproducible: Always

Steps to Reproduce:
1. Install Firefox Deer Park Alpha 1
2. Create a new Firefox profile for this test
3. Install several extensions of your choosing
4. Restart the browser
5. Install one or more themes of your choice.  Note:  I have replicated this bug
using both "Orbit 3+1" and "Brushed 0.9.9.2" - the only themes I have actually
tested for this bug.
6. Confirm that your extensions are operational
7. Restart the browser in Safe Mode
8. Right-click one of the themes you installed and uninstall it.
9. Restart the browser in normal operating mode
10. You should now notice that all your extensions are completely inactive and
cannot be enabled.

Actual Results:  
Apparent corruption in Extension Manager

Expected Results:  
Theme should have been uninstalled without corrupting Extension Manager

Comment 1

[Steve England [:stevee]]

Uninstalling a theme from safemode does not screw up my installed extensions in
any way for me.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050604
Firefox/1.0+ ID:2005060411

Comment 2

[IU]

Steve,

I am not sure why you were unable to reproduce it.  Assuming you followed my
instructions exactly, maybe this is an XP only bug?  Maybe there is a conflict
with XP's Data Execution Protection (DEP)? I have now reproduced it with Build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050604
Firefox/1.0+

I have reproduced it using both the firefox-1.0+.en-US.win32.installer.exe and
firefox-1.0+.en-US.win32.zip distributions.  I am running neither a personal
firewall nor AV software; thus, there is no such inteference.  I have a PIII and
DEP is enabled, as is the default.

Could someone with Windows XP, SP2 + patches, please test this.  Thanks

Comment 3

[Robert Strong (they/them - no direct email)]

Confirming using the provided steps

Comment 4

[Robert Strong (they/them - no direct email)]

I have a suspicion as to what the cause is and should be able to come up with a
patch soon.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

This should be all there is to it. I'm going to test for a short while before
requesting review.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 185373 [details] [diff] [review]
patch

Benjamin - this removes a section that was added by the patch for bug 285544
that I should have caught for removal during the review of the patch for bug
293461. I also looked over the patch from bug 285544 to make sure everything
that should have been removed has been.

Comment 7

[IU]

Robert,

Thanks for your work on this.  I have run into another way of triggering this
bug - still involving safe mode, but no themes - however, I will wait until your
patch gets merged to see if it resolves that too.

Comment 8

[Frank Wein [:mcsmurf]]

Comment on attachment 185373 [details] [diff] [review]
patch

I think we want this for 1.1...

Comment 9

[timeless]

Comment on attachment 185373 [details] [diff] [review]
patch

mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in 	1.116

Comment 10

[Robert Strong (they/them - no direct email)]

Resolving fixed - thanks for the checkin timeless. I also verified this now
works using the steps in comment #0.