Closed Bug 296643 Opened 15 years ago Closed 15 years ago

Uninstalling themes in Safe Mode kills extensions

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: fehe, Assigned: rstrong)

Details

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050603 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050603 Firefox/1.0+

If you uninstall a Firefox theme while in Safe Mode, firefox permanently
disables all extensions, and the extensions remain inactive and unusable when
running in normal operating mode.


Reproducible: Always

Steps to Reproduce:
1. Install Firefox Deer Park Alpha 1
2. Create a new Firefox profile for this test
3. Install several extensions of your choosing
4. Restart the browser
5. Install one or more themes of your choice.  Note:  I have replicated this bug
using both "Orbit 3+1" and "Brushed 0.9.9.2" - the only themes I have actually
tested for this bug.
6. Confirm that your extensions are operational
7. Restart the browser in Safe Mode
8. Right-click one of the themes you installed and uninstall it.
9. Restart the browser in normal operating mode
10. You should now notice that all your extensions are completely inactive and
cannot be enabled.

Actual Results:  
Apparent corruption in Extension Manager

Expected Results:  
Theme should have been uninstalled without corrupting Extension Manager
Version: unspecified → Trunk
Uninstalling a theme from safemode does not screw up my installed extensions in
any way for me.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050604
Firefox/1.0+ ID:2005060411
Steve,

I am not sure why you were unable to reproduce it.  Assuming you followed my
instructions exactly, maybe this is an XP only bug?  Maybe there is a conflict
with XP's Data Execution Protection (DEP)? I have now reproduced it with Build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050604
Firefox/1.0+

I have reproduced it using both the firefox-1.0+.en-US.win32.installer.exe and
firefox-1.0+.en-US.win32.zip distributions.  I am running neither a personal
firewall nor AV software; thus, there is no such inteference.  I have a PIII and
DEP is enabled, as is the default.

Could someone with Windows XP, SP2 + patches, please test this.  Thanks
Confirming using the provided steps
Status: UNCONFIRMED → NEW
Ever confirmed: true
I have a suspicion as to what the cause is and should be able to come up with a
patch soon.
Assignee: nobody → moz_bugzilla
Attached patch patch (obsolete) — Splinter Review
This should be all there is to it. I'm going to test for a short while before
requesting review.
Comment on attachment 185373 [details] [diff] [review]
patch

Benjamin - this removes a section that was added by the patch for bug 285544
that I should have caught for removal during the review of the patch for bug
293461. I also looked over the patch from bug 285544 to make sure everything
that should have been removed has been.
Attachment #185373 - Flags: review?(benjamin)
Robert,

Thanks for your work on this.  I have run into another way of triggering this
bug - still involving safe mode, but no themes - however, I will wait until your
patch gets merged to see if it resolves that too.
Attachment #185373 - Flags: review?(benjamin) → review+
Comment on attachment 185373 [details] [diff] [review]
patch

I think we want this for 1.1...
Attachment #185373 - Flags: approval-aviary1.1a2?
Attachment #185373 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Comment on attachment 185373 [details] [diff] [review]
patch

mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in 	1.116
Attachment #185373 - Attachment is obsolete: true
Resolving fixed - thanks for the checkin timeless. I also verified this now
works using the steps in comment #0.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.