Closed Bug 296678 Opened 20 years ago Closed 18 years ago

text underlines for links sometimes riding into text where the underline should be 1 or more pixels lower

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: chase, Assigned: pavlov)

Details

Attachments

(8 files, 2 obsolete files)

Screenshot of proper rendering of FTP directory contents
99.02 KB, image/jpeg
Details
Screenshot of bad rendering of FTP directory contents
106.82 KB, image/jpeg
Details
Screenshot of proper rendering of Tinderbox build display
96.48 KB, image/jpeg
Details
Screenshot of bad rendering of Tinderbox build display
99.43 KB, image/jpeg
Details
Screenshot of proper rendering of regular (non-link) underscores
135.40 KB, image/jpeg
Details
Screenshot of bad rendering of regular (non-link) underscores
133.94 KB, image/jpeg
Details
Screen shot of what I see on windows 1.5b1
25.41 KB, image/png
Details
Screenshot of TB1.0+Beta1 with wrong underlines
12.46 KB, image/png
Details 
In Deer Park Alpha 1 text which is underlined sometimes has the underline riding
into the bottom of the text where the underline should be lower away from the
text.  I noticed this before trying Deer Park Alpha 1 in nightlies a couple of
weeks before we released 1.1a1 so it's been around for at least that long.  That
was the first time I'd used a trunk nightly for a long time after staying on the
branch where this problem does not exist.

I'm running Deer Park Alpha 1 on Windows XP, Service Pack 2.  Intel Pentium M
processor with 1.5 GB of RAM.

I find it unlikely that I'm the first to file a bug on this.  I searched for
bugs that were dupes but couldn't find any.  Dupe as necessary if it's already
being tracked somewhere else.  Just wanted to make sure it was on file and
screenshots available if not already.
Links underlined properly.  The FTP directory was viewed using Firefox 1.0.4 on
my laptop.
Some links underlined incorrectly.  The FTP directory was viewed using Deer
Park Alpha 1 on my laptop.
Links underlined properly.  The Tinderbox page was viewed using Firefox 1.0.4
on my laptop.
Some links underlined incorrectly.  The Tinderbox page was viewed using Deer
Park Alpha 1 on my laptop.
Bug 273492 last place I saw this.
I saw this in Thunderbird 1.0+, too. But there only in text-mails.

Maybe you should mention the words "link" or "url" in the summary, so you can
find the bug easier.
Yes, good idea.
Summary: text underlines sometimes riding into text where the underline should be 1 or more pixels lower → text underlines for links sometimes riding into text where the underline should be 1 or more pixels lower
Nominating blocking1.8b4.  Gecko hackers make the call.
Flags: blocking1.8b4?
Close examination of the screenshot show that the problem is that the underline
is too high (rather than the text being too low).
Linux having a problem too: http://qa.mandriva.com/show_bug.cgi?id=14331
No, that's a different bug, and one that's already fixed.
(It looks like bug 210330, actually, which is actually a possible cause of this
regression, although it's hard to know without concrete regression dates.)
Comment on attachment 187316 [details]
Screenshot of proper rendering of regular (non-link) underscores

I'll reattach noting the areas where the rendering differs as in the other
screenshots.
Attachment #187316 - Attachment is obsolete: true
Attachment #187317 - Attachment is obsolete: true
Flags: blocking1.8b4? → blocking1.8b4-
Seems to occur more frequently with my monospace font (ProFont) though has been
seen using FixedSys at some font sizes.

Doesn't occur in 2005-03-28 windows, does occur in 2005-03-30 windows.
Almost definitely bug 173051 (I don't see anything else remotely related), but
probably best fixed elsewhere, either the Windows font code or perhaps more
general underline rounding code.  It would be interesting to know whether the
font provides underline metrics or we synthesize them.
Just installed Thunderbird 1.5b1.  I see this bug there, as well.
can you post a URL to a web page that has this problem? maybe a url from the
screen shot?
I see this bug on this bugzilla page. Look at one of the links that are to
resolved bugs and the strikethrough and the underline are horribly ill placed. 
(In reply to comment #23)
> can you post a URL to a web page that has this problem? maybe a url from the
> screen shot?

From the screenshots:
ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox (sb.cgi no longer exists)
http://article.gmane.org/gmane.comp.version-control.monotone.devel/3256
I'm unable to reproduce this on my windows beta 1 build. The underlining looks
fine.

Could it be a font issue where we are using different fonts or something?
(In reply to comment #26)
> I'm unable to reproduce this on my windows beta 1 build. The underlining looks
> fine.
> 
> Could it be a font issue where we are using different fonts or something?

Yes.  See comment 18 and comment 20.  I see this bug with ProFont and
occasionally with FixedSys.  I don't see this bug with Courier New.
As you can see in the screenshot, this is a mail of comment 25. When I see
comment 25 with FF1.5Beta1 everything looks fine :-(

In TB I have this issue with every text mail.
Assignee: nobody → pavlov
I don't believe this still happens.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: