Can't overlay the console's keyset (missing id)

VERIFIED FIXED in mozilla1.8final

Status

--
minor
VERIFIED FIXED
14 years ago
2 years ago

People

(Reporter: zeniko, Assigned: zeniko)

Tracking

({fixed1.8})

unspecified
mozilla1.8final
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050601 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050601 Firefox/1.0+

For my "Console Filter" extension, I wanted to add a new keyboard shortcut for
the JS console. Since the console's keyset is missing an id attribute, it can't
be simply overlayed. Since keys in a different keyset seem no to be recognized,
a JavaScript work-around is necessary.

Adding id="consoleKeys" to the keyset in chrome://global/content/console.xul
should fix this.

Reproducible: Always

Steps to Reproduce:
1. Create an extension which overlays chrome://global/content/console.xul with a
keyset (resp. have a look at "Console Filter").

Actual Results:  
The new keys aren't recognized (if the keyset in the overlay has an id, it is
missing, otherwise the keys can be moved to the right keyset through JavaScript).

Expected Results:  
The new keyset is correctly overlayed.

Updated

14 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 1

14 years ago
Created attachment 190662 [details] [diff] [review]
keyset id added
Attachment #190662 - Flags: review?(mconnor)

Updated

14 years ago
Assignee: nobody → zeniko

Updated

14 years ago
Whiteboard: [no l10n impact], has patch
Comment on attachment 190662 [details] [diff] [review]
keyset id added

r=mano
Attachment #190662 - Flags: review?(mconnor) → review+
Checked into trunk; also added an id to the commandset.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.6-

Updated

13 years ago
Attachment #190662 - Flags: approval1.8b4? → approval1.8b4+

Comment 4

13 years ago
Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.
1.8 branch:
Checking in console.xul;
/cvsroot/mozilla/toolkit/components/console/content/console.xul,v  <--  console.xul
new revision: 1.5.10.1; previous revision: 1.5
done
Keywords: fixed1.8
Whiteboard: [no l10n impact], has patch
Target Milestone: Firefox1.6- → Firefox1.5
(Assignee)

Updated

12 years ago
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.