296707 - Bug 295494 breakage: errors in config/rules.mk during "make install"

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bastiaan Jacques]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050605 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050605 Firefox/1.0+

firefox "make install" fails with:

/home/baafie/src/mozilla/obj-ff-trunk-gcc/config/nsinstall -D
"/usr/lib/firefox-1.0+/[e-mail]"
cd ../../dist/xpi-stage/inspector && tar -cvhf - * | (cd
"/usr/lib/firefox-1.0+/extensions/[e-mail] && tar -xf -)
/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file
make[2]: *** [install] Error 2
make[2]: Leaving directory
`/home/baafie/src/mozilla/obj-ff-trunk-gcc/extensions/inspector'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/baafie/src/mozilla/obj-ff-trunk-gcc/extensions'
make: *** [install] Error 2

Reproducible: Always

Steps to Reproduce:
1. type make install
2. ..
3. profit!!

Actual Results:  
build failed. boo-hoo

Expected Results:  
succeed in installing.

these are the relevant lines from config/rules.mk:
1654                    install::
1655                    	$(NSINSTALL) -D
"$(DESTDIR)$(mozappdir)/$(INSTALL_EXTENSION_ID)"
1656                    	cd $(FINAL_TARGET) && tar $(TAR_CREATE_FLAGS) - * | (cd
"$(DESTDIR)$(mozappdir)/extensions/$(INSTALL_EXTENSION_ID) && tar -xf -)
1657                    endif


The first obvious problem is the mismatching of double quotes on line 1656. In
addition, $(DESTDIR)$(mozappdir)/$(INSTALL_EXTENSION_ID) is created, whilst the
author presumably intended to create
$(DESTDIR)$(mozappdir)/extensions/$(INSTALL_EXTENSION_ID).

Comment 1

[Bastiaan Jacques]

Attachment: Fix

Create the correct directory and match the double quotes.

Comment 2

[Raphaël Slinckx]

*** Bug 296706 has been marked as a duplicate of this bug. ***

Comment 3

[Benjamin Smedberg]

Comment on attachment 185399 [details] [diff] [review]
Fix

r+a=me

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in config/rules.mk;
/cvsroot/mozilla/config/rules.mk,v  <--  rules.mk
new revision: 3.476; previous revision: 3.475
done