296713 - XForms is leaking control elements

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

patch coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v.1

We should not hold a strong ref to the mElement.
I added also some DEBUG_smaug code to see whether we are still leaking.
Note, when using that debug code, some non-xforms pages have to be loaded
after xforms pages, so that xforms documents are GC'd.

I'm not too happy with the hack in the <select> but that is needed the prevent
leaks.

Comment 2

[Allan Beaufour]

Comment on attachment 185413 [details] [diff] [review]
v.1

>Index: nsXFormsControlStub.cpp
>===================================================================
>+  ControlDebug() {
>+    sControlList = new nsVoidArray();
>+  }

Add assertion for null return.

>Index: nsXFormsSelectElement.cpp
>===================================================================
>+  // XXX This is needed to fix memory leaks.
>+  RemoveChildren(mSelect);

Why is that?

You need to document RemoveChildren and/or the call. And why is this an XXX?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 4

[Allan Beaufour]

Checked in.