296729 - staged-xpis directory does not get deleted upon failed extension installation

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Mike Pesce (:By-Tor)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050605 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050605 Firefox/1.0+

When installing an extension that has not been updated for the current version
of Firefox, the extension is put in the staged-xpis directory and never deleted.

Reproducible: Always

Steps to Reproduce:
1. Install an extension that is not compatible with Firefox 1.0+
2.
3.

Actual Results:  
Receive warning that extension is not compatible, then the extension just stays
in the staged-xpis directory.

Expected Results:  
The extension should be deleted from the staged-xpis directory and proper
housekeeping should be peformed.

Comment 1

[Robert Strong (they/them - no direct email)]

There have been quite a few EM changes recently and I am not able to reproduce
using an incompatible extension dropped onto the EM window from my local
filesystem. Can you please confirm if this bug is still present?

Comment 2

[Robert Strong (they/them - no direct email)]

Mike, I believe this bug has been fixed by a couple of recent checkins. Can you
please confirm that it is?

Comment 3

[Mike Pesce (:By-Tor)]

Yes, I just tested it and it is fixed.  Although, I didn't receive a warning
stating that it was an incompatible extension.  I guess that's another bug
though.  So, this one can be closed.

Comment 4

[Robert Strong (they/them - no direct email)]

Mike, can you provide a link to the extension that was not compatible? It has
been notifying me for extensions that are not compatible.

Comment 5

[Mike Pesce (:By-Tor)]

The extension has been updated, but the version I was using is at
http://tech-x.us/Print_It!_0.3.1.xpi

Comment 6

[Robert Strong (they/them - no direct email)]

The extension from that link has a maxVersion of 1.0+ and since it is compatible
it isn't another bug and it shouldn't give a warning.

Comment 7

[Mike Pesce (:By-Tor)]

Oops!  That was my fault.  I had edited it and forgotten about it.  It just
fails to install.  Case closed.  :)