296745 - history lists URL of previous page instead of current one with bfcache enabled

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Benoît]

User-Agent:       Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8b2) Gecko/20050530
Build Identifier: Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.8b2) Gecko/20050530

In History, the titles of pages you visited is that of the page you were on
before accessing it when exiting them with the Back button.

Say you are on Google. Now click on a bookmark that leads you to mozilla.org.
Press Back. Now go into your History, and look up your entry of
http://www.mozilla.org/. It will read "Google" instead of the site's title.

This happens only with bfcache enabled.

Reproducible: Always

Steps to Reproduce:
1. Load a page. Any page.
2. Click on a link on that page, or click a bookmark.
3. Press Back.
4. Look up the page you just visited in History.

Actual Results:  
The title listed is that of the previous page.

Expected Results:  
Listed the last visited page's title.

Comment 1

[kmike]

Confirming in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050529
build.

Comment 2

[Dimitrios]

Can easily reproduce it, following reporter's steps on build 20050607/WinXP. The
history entry'stitle is corrected only when you click on it (and the page is
loaded again). This breaks an essential History feature. Additionally it might
be the cause of bug 293235. ->NEW, Severity->Normal, OS->All.
Perhaps a fallout of an already reported bfcache bug that it's too technical for
us non-hackers to understand. If that is the case, better don't duplicate this
one because the summary makes it easy to verify whether it has been fixed or not.

Comment 3

[Dimitrios]

forget my speculation about bug 293235. Doesn't seem related, the uri is
correctly stored.

Comment 4

[Brian Ryner (not reading)]

Attachment: move the title-restore later

Don't restore the title until mOSHE and mCurrentURI are updated to the new
page.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 186714 [details] [diff] [review]
move the title-restore later

darin, feel free to r/sr as well if boris can't get to this

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 186714 [details] [diff] [review]
move the title-restore later

switching reviewers, boris is away for awhile

Comment 7

[Darin Fisher]

Comment on attachment 186714 [details] [diff] [review]
move the title-restore later

Very obvious fix.  r+sr=darin

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 186714 [details] [diff] [review]
move the title-restore later

Requesting approval for fastback fix. Does not impact non-fastback.

Comment 9

[Brian Ryner (not reading)]

checked in

Comment 10

[Dimitrios]

verified fixed with FF 20050621 on WinXP.