296819 - libxul.so cannot be linked --with-system-nspr

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

There is another build-system issue when --with-system-nspr is used:

libmozcairo can't be found anymore

rm -f libxul.so
c++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-pr
ivacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -O2 -march=i586 -mtune=i686
-fmessage-length=0 -Wall -g -Os -fno-strict-aliasing -fshort-wch
ar -pthread -pipe  -DNDEBUG -DTRIMMED -O2 -march=i586 -mtune=i686
-fmessage-length=0 -Wall -g -Os -fno-strict-aliasing -fPIC -shared -Wl,-h -Wl,l
ibxul.so -o libxul.so  nsStaticXULComponents.o       -Wl,--whole-archive
../../dist/lib/libxpcom_core.a ../../dist/lib/libxpcom_compat.a ../../di
st/lib/libunicharutil_s.a ../../dist/lib/libucvutil_s.a
../../dist/lib/libgkgfx.a ../../dist/lib/libgfxshared_s.a
../../dist/lib/libxulapp_s.a ..
/../dist/lib/libgtkxtbin.a ../../dist/lib/libgfxpsshar.a ../../dist/lib/libjsj.a
../../dist/lib/components/libxpcom_compat_c.a ../../dist/lib/com
ponents/libxpconnect.a ../../dist/lib/components/libnecko.a
../../dist/lib/components/libuconv.a ../../dist/lib/components/libi18n.a
../../dist/l
ib/components/libjar50.a ../../dist/lib/components/libpref.a
../../dist/lib/components/libcaps.a ../../dist/lib/components/librdf.a ../../dist/li
b/components/libhtmlpars.a ../../dist/lib/components/libimglib2.a
../../dist/lib/components/libgkplugin.a ../../dist/lib/components/libgklayout.a
 ../../dist/lib/components/libdocshell.a
../../dist/lib/components/libembedcomponents.a
../../dist/lib/components/libwebbrwsr.a ../../dist/lib/co
mponents/libeditor.a ../../dist/lib/components/libnsappshell.a
../../dist/lib/components/libtxmgr.a ../../dist/lib/components/libcomposer.a ../..
/dist/lib/components/libchrome.a ../../dist/lib/components/libmork.a
../../dist/lib/components/libmozfind.a ../../dist/lib/components/libappcomps
.a ../../dist/lib/components/libcommandlines.a
../../dist/lib/components/libtoolkitcomps.a
../../dist/lib/components/libxpinstall.a ../../dist/li
b/components/libjsd.a ../../dist/lib/components/libucvmath.a
../../dist/lib/components/libwidget_gtk2.a ../../dist/lib/components/libnecko2.a ../
../dist/lib/components/libgfxps.a ../../dist/lib/components/libgfx_gtk.a
../../dist/lib/components/liboji.a ../../dist/lib/components/libaccessib
ility.a ../../dist/lib/components/libremoteservice.a  -Wl,--no-whole-archive
-Wl,-rpath-link,../../dist/bin -ljpeg  -lpng  -L../../dist/bin -lmoz
js  -lz   -L/usr/lib -lplds4 -lplc4 -lnspr4 -lpthread -ldl -L/usr/X11R6/lib
-lX11   -L/usr/X11R6/lib   -lXft -lX11 -lfreetype -lXrender -lfontcon
fig   -L/opt/gnome/lib   -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgdk_pixbuf-2.0
-lm -lpangoxft-1.0 -lpangox-1.0 -lpango-1.0 -lgobject-2.0 -lgmodu
le-2.0 -ldl -lglib-2.0   -lXt -lmozcairo -lmozlibpixman  -L/usr/X11R6/lib
-lXrender -lfreetype -ldl -lm     
/usr/lib/gcc/i586-suse-linux/4.0.1/../../../../i586-suse-linux/bin/ld: cannot
find -lmozcairo
collect2: ld returned 1 exit status
gmake[3]: *** [libxul.so] Error 1

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

libmozcairo seems to be in ../../dist/lib/ which isn't defined as library
location when --with-system-nspr is used.

Comment 2

[Benjamin Smedberg]

I presume you just need to add an extra $(LIBS_DIR) to EXTRA_DSO_LDOPTS

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

will try that and report back (in some hours). Thanks

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Can I just add it or should it depend on --with-system-nspr?

Comment 5

[Benjamin Smedberg]

You can just add it, an extra -L won't hurt anyone.

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

Comment 7

[Allan Beaufour]

Checked in.