Able to press Cancel when the "Browse for Folder" dialog is open

VERIFIED FIXED

Status

P3
normal
VERIFIED FIXED
19 years ago
14 years ago

People

(Reporter: bugzilla, Assigned: law)

Tracking

Trunk
x86
Windows 98

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
Reproduce:
- Go into Create New Profile
- Go to page 2
- Press Change Folder
- Now press Cancel in the Create New Profile window leaving the "Browse for 
Folder" dialog open.

Expected:
It should NOT be possible to press cancel if the "Browse for Folder" dialog is 
open.

Important:
If you have no Mozilla profiles pressing Cancel will leed to a CRASH!. Otherwise 
the Crash will first happen when you press Exit in the Select Profile dialog!
the folder picker should be modal. sounds like its not. This is not a profile 
manager problem I dont think. Reassigning...

dougt, are you the right person to give these to or am I starting to piss you 
off? ;)
Assignee: ben → dougt

Comment 2

19 years ago
need more info.  this probably should go to the profile folks for isolation.  
selmer?
Assignee: dougt → selmer

Comment 3

19 years ago
Doug, your comment makes no sense to me.  _Ben_ is the profile front end person 
and he's asking for your help.  To reiterate, are you the right person to help 
make the dialog modal?

The crash happens in other similar circumstances and is probably docshell.  If 
you close the window that spawned the dialog, you will crash the next time the 
dialog does anything.  Anyway, Ben seems to want to make the problem go away by 
preventing it in the first place and that's probably the best course right now.
Assignee: selmer → dougt

Comment 4

19 years ago
targeting m16.  If you reported this bug, and you would like to have it fixed 
sooner, please send me email.  I will see what I can do.  :-)
Target Milestone: M16

Comment 5

19 years ago
pavlov, is this something that you fixed?

Comment 6

19 years ago
spoke to pavlov.  He told me that law would own this one.  over to him.
Assignee: dougt → law
(Assignee)

Comment 7

19 years ago
Me?

In the past, I added a "parentWindow" attribute to nsFileSpecWithUIImpl to make 
file picker dialogs modal.  Is the profile code using that interface 
(nsIFileSpecWithUI), or, is it using nsIFilePicker.  The latter has a means of 
specifying the parent window, also (which I presumes makes it modal).

If the code in question is using nsIFileSpecWithUI, then somebody should fix it.  
If not to use nsIFilePicker immediately, then to set the parentWindow property 
of the filespecwithui object.  I'll go find the code and take care of this, I 
guess.
Status: NEW → ASSIGNED

Updated

19 years ago
Target Milestone: M16 → M18

Comment 8

19 years ago
???
This is fixed by bug 23705.  I have no permission to close.
law, you should close...

Comment 9

19 years ago
Move to M21 target milestone.
Target Milestone: M18 → M21
(Reporter)

Comment 10

18 years ago
This seems to have been fixed in build 2000061820
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 11

18 years ago
build 2000061220
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.