29682 - Able to press Cancel when the "Browse for Folder" dialog is open

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect, P3)

Description

[Henrik Gemal]

Reproduce:
- Go into Create New Profile
- Go to page 2
- Press Change Folder
- Now press Cancel in the Create New Profile window leaving the "Browse for 
Folder" dialog open.

Expected:
It should NOT be possible to press cancel if the "Browse for Folder" dialog is 
open.

Important:
If you have no Mozilla profiles pressing Cancel will leed to a CRASH!. Otherwise 
the Crash will first happen when you press Exit in the Select Profile dialog!

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

the folder picker should be modal. sounds like its not. This is not a profile 
manager problem I dont think. Reassigning...

dougt, are you the right person to give these to or am I starting to piss you 
off? ;)

Comment 2

[Doug Turner (:dougt)]

need more info.  this probably should go to the profile folks for isolation.  
selmer?

Comment 3

[selmer (gone)]

Doug, your comment makes no sense to me.  _Ben_ is the profile front end person 
and he's asking for your help.  To reiterate, are you the right person to help 
make the dialog modal?

The crash happens in other similar circumstances and is probably docshell.  If 
you close the window that spawned the dialog, you will crash the next time the 
dialog does anything.  Anyway, Ben seems to want to make the problem go away by 
preventing it in the first place and that's probably the best course right now.

Comment 4

[Doug Turner (:dougt)]

targeting m16.  If you reported this bug, and you would like to have it fixed 
sooner, please send me email.  I will see what I can do.  :-)

Comment 5

[Doug Turner (:dougt)]

pavlov, is this something that you fixed?

Comment 6

[Doug Turner (:dougt)]

spoke to pavlov.  He told me that law would own this one.  over to him.

Comment 7

[Bill Law]

Me?

In the past, I added a "parentWindow" attribute to nsFileSpecWithUIImpl to make 
file picker dialogs modal.  Is the profile code using that interface 
(nsIFileSpecWithUI), or, is it using nsIFilePicker.  The latter has a means of 
specifying the parent window, also (which I presumes makes it modal).

If the code in question is using nsIFileSpecWithUI, then somebody should fix it.  
If not to use nsIFilePicker immediately, then to set the parentWindow property 
of the filespecwithui object.  I'll go find the code and take care of this, I 
guess.

Comment 8

[Makoto Kato [:m_kato]]

???
This is fixed by bug 23705.  I have no permission to close.
law, you should close...

Comment 9

[don]

Move to M21 target milestone.

Comment 10

[Henrik Gemal]

This seems to have been fixed in build 2000061820

Comment 11

[Grace Bush]

build 2000061220