Closed Bug 296865 Opened 20 years ago Closed 20 years ago

fixes for addPermission

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

Attachments

(1 file)

patch
2.63 KB, patch
asa
: approval-aviary1.1a2+
Details | Diff | Splinter Review
In reviewing Bug 293826, I ran across a couple issues in addPermission. One was broken feedback (missing/broken bits for the prompt on bad input) and the other was just unnecessary extra and broken code for the nsIPermissionManager.add call. Patch upcoming.
Attached patch patch — — Splinter Review
Assignee: nobody → mconnor
Status: NEW → ASSIGNED
Attachment #185503 - Flags: approval-aviary1.1a2?
Summary: fixes for addPermission → fixes for addPermission
Attachment #185503 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: