29695 - Text->HTML ;) should equal ;-) wink.gif

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P5)

Description

[Alan S. Jones]

In chatting with others we would like ;) to display wink.gif like ;-)
in the TEXT -> HTML conversion

Comment 1

[Ben Bucksch (:BenB)]

Who is "we"?

"Chat"? You mean, you want the substitution for a chat client or you discussed
via chat about it?

We have to draw a line somewhere. See bug #23327.

Comment 2

[Alan S. Jones]

Lisa and I and I agreed that many people use ;) not just ;-) for a wink.

Comment 3

[Ben Bucksch (:BenB)]

This will give a small performance hit, but I think, this is worth it.
ACCEPTing.

Comment 4

[Ben Bucksch (:BenB)]

Mass-LATER

Comment 5

[Ben Bucksch (:BenB)]

Attaching patch. mscott, could you please "review" and check in? tnx.

Comment 6

[Ben Bucksch (:BenB)]

Attachment: Patch, try 1

Comment 7

[Ben Bucksch (:BenB)]

ops, I got confused of what version I'm running. The patch is against my
nsString version, I think. I'll give a better patch later.

Comment 8

[selmer (gone)]

Mass moving to M16 to get these off the M15 radar.  Please let me know if this
is really an M15 stopper.

Comment 9

[Ben Bucksch (:BenB)]

Wait, the following is legal C++ code:
for (int i=0; i<10 ;)
I can't (resonably) recognize the code, so we have to do a tradeoff. This code
will be *very* rare, but a smily at the end of a for statement is bad :-). Not
sure, what to do. Comments?

Comment 10

[Blake Ross]

moving to m17, this won't make it by 5/16 freeze

Comment 11

[Ben Bucksch (:BenB)]

> this won't make it by 5/16 freeze

huh? Do you know something I don't?

This is extremely trivial to fix. Question is "Should we?". If yes, M16. If no,
WONTFIX. M17 doesn't make sense.

So, should we? (see above for discussion.)

Comment 12

[Blake Ross]

Sorry 'bout that - you said earlier you'd give a better patch later, then I 
thought you indicated you weren't quite sure how to fix.  Then I didn't see any 
other notice for about a month, so I figured you were busy with other (more 
important issues).  I also didn't think you'd get to this by M16 freeze, and 
it's not significant enough to hold it up.

My bad, sorry again..

Comment 13

[Ben Bucksch (:BenB)]

ok, np.

Comment 14

[Ben Bucksch (:BenB)]

checked in

Comment 15

[Ben Bucksch (:BenB)]

ops

Comment 16

[lchiang]

Alan - can you help me verify this? Thanks.

Comment 17

[Alan S. Jones]

Ben, when did this land?  I did not see it in the last 24 hour checkin list.
If it lanted today 5/17 i am assumeing it won't be in till the 5/18 build.

Comment 18

[Ben Bucksch (:BenB)]

checked in by mscott with bug 32420.

Comment 19

[Alan S. Jones]

cool  ;) now is the same as ;-)
good work verified on Win95
Lisa, with this type of fix do we need to bother verifying on Linux/Mac?

Comment 20

[lchiang]

I think it's ok not the verify on Linux and Mac.  Thanks, Alan!

Comment 21

[Ben Bucksch (:BenB)]

verified linux 2000-05-17-15 build