296957 - Checking for updates creates blank window that states: updates found - nothing listed

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050607 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050607 Firefox/1.0+

Open the EM and highlight an extension.
Firefox will check and advise that updates are found but the list is 'blank'
Button to Install updates now is highlighted, clicking 'Install Now' states that
Updates are complete, restart Firefox to complete.

No update takes place. 

Reproducible: Always

Steps to Reproduce:
1.Open EM
2.Highlight any extension and choose 'Update'
3.Returns with 'Update to Extensions/Themes found' but the list of extensions
that need an update is blank.  Install now button is 'active', clicking Install
results in no updates taking place, but advises that updates are complete,
please restart Firefox to activate.

Actual Results:  
No updates were applied.  No extensions were listed when checking for update.

Expected Results:  
Updated the Extension if update is available, or advised that No updates are found.

Comment 1

[Dave Townsend [:mossop]]

The software update patches are in the process of being landed. Things are not
likely to work until after they are all in.

Comment 2

[Jim Jeffery not reading bug-mail 1/2/11]

This regressed from 292566 Move Extension Update to EM

Comment 3

[Jim Ginn]

Because Bug 296566 is not closed and all of the changes have not landed,
shouldn't this be resolved as a dupe of that bug?

Comment 4

[Peter van der Woude [:Peter6]]

(In reply to comment #3)
> Because Bug 296566 is not closed and all of the changes have not landed,
> shouldn't this be resolved as a dupe of that bug?

No, I added the status whiteboard comment.
Let's just wait for Ben to finish the job.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch

Benjamin - it looks like some of the software update changes stomped on a
couple of recent changes as well as had a couple of minor errors - this gets
update for the EM working again.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 185763 [details] [diff] [review]
patch

This fixed 'most' of the errors but I need to spend some qiality time with the
code first.

Comment 7

[Robert Strong (they/them - no direct email)]

This is WFM after the patch for bug 296578 landed. I suspect there are other
bugs with update but performing the steps in comment #0 are now WFM.