296965 - [FIXr]Make scrollIntoView on nsIDOMNSHTMLElement scriptable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Right now, scrollIntoView doesn't work on XPCNativeWrappers, because the
function is not scriptable in IDL.  We should make it scriptable (with the
required boolean arg) just like document.open is done.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

No need for new iid, since this isn't changing the vtable...

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 191145 [details] [diff] [review]
Patch

r+sr=jst

(there's a reason for the odd indentation/spacing here, consistency with the
spec indentation. But that's sort of moot in this file, and lost too, since
blur() and focus() don't follow the same scheme... wanna just make
scrollIntoView() indentation match focus and blur here while you're at it?)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk and 1.8 branch.

Comment 4

[Jesse Ruderman]

This change might have been unnecessary after the patch for 296967. 
formElement.scrollIntoView worked for me in Greasemonkey scripts in Aug 11
builds, for example.

Comment 5

[Boris Zbarsky [:bzbarsky]]

It's not necessary in the obvious cases, but it's still needed in general (eg
for the xpt files for the interface to contain this method, etc).