potential OOM crash [@ nsNativeAppSupportWin::GetCmdLineArgs]

RESOLVED FIXED

Status

()

Core
Widget: Win32
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

13 years ago
this code is from Cenzic Hailstorm 2.6
(Assignee)

Comment 1

13 years ago
Created attachment 185678 [details] [diff] [review]
handle alloc failure
(Assignee)

Updated

13 years ago
Assignee: win32 → timeless
Status: NEW → ASSIGNED
Attachment #185678 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #185678 - Flags: review?(neil.parkwaycc.co.uk)

Comment 2

13 years ago
Comment on attachment 185678 [details] [diff] [review]
handle alloc failure

rs=me
Attachment #185678 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #185678 - Flags: superreview+
Attachment #185678 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #185678 - Flags: review+

Comment 3

13 years ago
Comment on attachment 185678 [details] [diff] [review]
handle alloc failure

hmm, won't a break just fall through to the aResult = do_CreateInstance(
COMMANDLINESERVICE, &rv ); so it won't crash but it won't return failure...
(Assignee)

Updated

13 years ago
Attachment #185678 - Flags: approval1.8b3?

Comment 4

13 years ago
Comment on attachment 185678 [details] [diff] [review]
handle alloc failure

a=chofmann
Attachment #185678 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Comment 5

13 years ago
Comment on attachment 185678 [details] [diff] [review]
handle alloc failure

mozilla/xpfe/bootstrap/nsNativeAppSupportWin.cpp	1.120
Attachment #185678 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.