Open
Bug 297089
Opened 19 years ago
Updated 2 years ago
Provide a way for embedders to disable printing
Categories
(Core :: Printing: Output, enhancement)
Tracking
()
NEW
People
(Reporter: timeless, Unassigned)
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
this code is from Cenzic Hailstorm 2.5-2.6
Attachment #185684 -
Flags: superreview?(jst)
Attachment #185684 -
Flags: review?(jst)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 185684 [details] [diff] [review]
patch we used
- In nsPrintEngine::PrintPreview():
+ if (prefBranch) {
...
+ }
+
+
nsresult rv = NS_OK;
I'd remove the second empty line there...
r+sr=jst either way...
Attachment #185684 -
Flags: superreview?(jst)
Attachment #185684 -
Flags: superreview+
Attachment #185684 -
Flags: review?(jst)
Attachment #185684 -
Flags: review+
|
||
Comment 3•19 years ago
|
||
+ nsCOMPtr<nsIPrefBranch> prefBranch(do_GetService(NS_PREFSERVICE_CONTRACTID));
why not use nsContentUtils::Get*Pref?
|
||
Updated•15 years ago
|
QA Contact: printing
|
||
Comment 4•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: timeless → nobody
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•