Closed
Bug 297118
Opened 19 years ago
Closed 19 years ago
Remove afxres.h dependency from new update code
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mcsmurf, Assigned: mcsmurf)
Details
Attachments
(1 file, 1 obsolete file)
693 bytes,
patch
|
cls
:
review+
darin.moz
:
superreview+
asa
:
approval-aviary1.1a2+
|
Details | Diff | Splinter Review |
When you build with MS VC6 and don't have this file installed for some reason (i think it has to do with atl/mfc classes, if those are installed), the build fails in toolkit/mozapps/update with: /updater/module.rc(55) : fatal error RC1015: cannot open include file 'afxres.h' I think this dependency can/should be replaced with winres.h (i did it manually and the build just worked fine). Before the checkin of the new code, only mfcembed.exe relied on afxres.h (naturally).
Comment 1•19 years ago
|
||
This also breaks building with the free MSVC++ Toolkit <http://whereswalden.com/mozilla/msvcfree/>.
Comment 2•19 years ago
|
||
So, because I'm using an older SDK, the afxres.h thing might not be as big a deal, because the latest one apparently has it. It also has winres.h, which the older one doesn't have (and consequently makes the workaround posted here a no-go for me). Basically, I think we're back to just a technical issue, not an issue that prevents builds from being done. And with that, I promise I'm done posting until after I've at least tested out the new SDK. :-) Sorry for these two bits of bugspam...
Updated•19 years ago
|
Assignee: nobody → darin
Assignee | ||
Comment 3•19 years ago
|
||
Updated•19 years ago
|
Attachment #185814 -
Flags: review?(darin) → review+
Comment 4•19 years ago
|
||
Well, mingw also doesn't seem to have a winres.h file, so this patch doesn't work for mingw.
Comment on attachment 185814 [details] [diff] [review] Patch The 2.5 & 3.2 (latest) releases of the w32api used by mingw have afsxres.h & winresrc.h but not winres.h. winres.h appears to be mfc specific.
Attachment #185814 -
Flags: superreview-
Assignee | ||
Comment 6•19 years ago
|
||
Well my system had it ;) and some websites recommened replacing afxres.h with winres.h then. So what now?
Assignee | ||
Comment 7•19 years ago
|
||
Attachment #185814 -
Attachment is obsolete: true
Attachment #185844 -
Flags: superreview?(cls)
Attachment #185844 -
Flags: review?(cls)
Attachment #185844 -
Flags: superreview?(cls)
Attachment #185844 -
Flags: review?(cls)
Attachment #185844 -
Flags: review+
Assignee | ||
Updated•19 years ago
|
Attachment #185844 -
Flags: superreview?(darin)
Comment 8•19 years ago
|
||
Comment on attachment 185844 [details] [diff] [review] Like this? fun
Attachment #185844 -
Flags: superreview?(darin) → superreview+
Assignee | ||
Updated•19 years ago
|
Attachment #185844 -
Flags: approval-aviary1.1a2?
Updated•19 years ago
|
Attachment #185844 -
Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Comment 9•19 years ago
|
||
Comment on attachment 185844 [details] [diff] [review] Like this? Checking in toolkit/mozapps/update/src/updater/updater.rc; /cvsroot/mozilla/toolkit/mozapps/update/src/updater/updater.rc,v <-- updater.rc new revision: 1.3; previous revision: 1.2 done
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•