Closed Bug 297118 Opened 19 years ago Closed 19 years ago

Remove afxres.h dependency from new update code

Categories

(Toolkit :: Application Update, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mcsmurf, Assigned: mcsmurf)

Details

Attachments

(1 file, 1 obsolete file)

When you build with MS VC6 and don't have this file installed for some reason (i
think it has to do with atl/mfc classes, if those are installed), the build
fails in toolkit/mozapps/update with:
/updater/module.rc(55) : fatal error RC1015: cannot open include file 'afxres.h'

I think this dependency can/should be replaced with winres.h (i did it manually
and the build just worked fine). Before the checkin of the new code, only
mfcembed.exe relied on afxres.h (naturally).
This also breaks building with the free MSVC++ Toolkit
<http://whereswalden.com/mozilla/msvcfree/>.
So, because I'm using an older SDK, the afxres.h thing might not be as big a
deal, because the latest one apparently has it.  It also has winres.h, which the
older one doesn't have (and consequently makes the workaround posted here a
no-go for me).  Basically, I think we're back to just a technical issue, not an
issue that prevents builds from being done.

And with that, I promise I'm done posting until after I've at least tested out
the new SDK. :-)  Sorry for these two bits of bugspam...
Assignee: nobody → darin
Attached patch Patch (obsolete) — Splinter Review
Assignee: darin → bugzilla
Status: NEW → ASSIGNED
Attachment #185814 - Flags: review?(darin)
Attachment #185814 - Flags: review?(darin) → review+
Well, mingw also doesn't seem to have a winres.h file, so this patch doesn't
work for mingw.
Comment on attachment 185814 [details] [diff] [review]
Patch

The 2.5 & 3.2 (latest) releases of the w32api used by mingw have afsxres.h &
winresrc.h but not winres.h.  winres.h appears to be mfc specific.
Attachment #185814 - Flags: superreview-
Well my system had it ;) and some websites recommened replacing afxres.h with
winres.h then. So what now?
Attached patch Like this?Splinter Review
Attachment #185814 - Attachment is obsolete: true
Attachment #185844 - Flags: superreview?(cls)
Attachment #185844 - Flags: review?(cls)
Attachment #185844 - Flags: superreview?(cls)
Attachment #185844 - Flags: review?(cls)
Attachment #185844 - Flags: review+
Attachment #185844 - Flags: superreview?(darin)
Comment on attachment 185844 [details] [diff] [review]
Like this?

fun
Attachment #185844 - Flags: superreview?(darin) → superreview+
Attachment #185844 - Flags: approval-aviary1.1a2?
Attachment #185844 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Comment on attachment 185844 [details] [diff] [review]
Like this?

Checking in toolkit/mozapps/update/src/updater/updater.rc;
/cvsroot/mozilla/toolkit/mozapps/update/src/updater/updater.rc,v  <-- 
updater.rc
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: