297137 - xforms-ready fires too early

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

xforms-ready fires before the deferred binds are processed.  So actions keying
off of xforms-ready will be running before all of the attributes are set on the
controls.

Comment 1

[aaronr]

Attachment: testcase that shows the problem

when testcase loads, focus should be in the input field.  I set up a
xf:setfocus to be triggered when xforms-ready is fired.  Right now this doesn't
work because the attributes aren't set on the controls until after xforms-ready
is fired.  This causes TryFocus will fail since the 'enabled' attr isn't set
until ProcessDeferredBind is called.

Comment 2

[aaronr]

Attachment: first attempt

move xforms-ready post until after we process the deferred binding.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #2)
> Created an attachment (id=185744) [edit]
> first attempt
> 
> move xforms-ready post until after we process the deferred binding.

the patch is not up-to-date with cvs.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 185744 [details] [diff] [review]
first attempt

but looking good.

Comment 5

[aaronr]

Attachment: updated to trunk

same patch, updated to trunk

Comment 6

[Allan Beaufour]

Comment on attachment 185760 [details] [diff] [review]
updated to trunk

r=me

Does this also fix my problem in:
https://bugzilla.mozilla.org/show_bug.cgi?id=289434#c31

Comment 7

[aaronr]

(In reply to comment #6)
> (From update of attachment 185760 [details] [diff] [review] [edit])
> r=me
> 
> Does this also fix my problem in:
> https://bugzilla.mozilla.org/show_bug.cgi?id=289434#c31
> 

Yep, fixes it on my machine when I apply the 289434 patch.

Comment 8

[Doron Rosenberg (IBM)]

checked in

Comment 9

[Allan Beaufour]

(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 185760 [details] [diff] [review] [edit] [edit])
> > r=me
> > 
> > Does this also fix my problem in:
> > https://bugzilla.mozilla.org/show_bug.cgi?id=289434#c31
> > 
> 
> Yep, fixes it on my machine when I apply the 289434 patch.

Also here. With the widget patch you can now listen for "xforms-ready", retrieve
the ".value" and check it against the correct value for testing. Not bad.