Closed Bug 297144 Opened 19 years ago Closed 19 years ago

avoid creating mork xpcom wrappers for link-visited check

Categories

(Core Graveyard :: History: Global, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

(Keywords: perf)

Attachments

(1 file)

Currently, we force mork to create an nsIMdbRow object when checking to see if a
link is in history.  This is a waste since we can just use the row id to get the
same effect.  This also requires a small fix to mork to actually avoid creating
the object.
Attached patch patchSplinter Review
Attachment #185732 - Flags: superreview?(bzbarsky)
Attachment #185732 - Flags: review?(mconnor)
Comment on attachment 185732 [details] [diff] [review]
patch

bz's on "vacation" and only has access to a win98 box, so this'll be a spotty
response.
Attachment #185732 - Flags: review?(mconnor) → review+
Comment on attachment 185732 [details] [diff] [review]
patch

>Index: db/mork/src/morkStore.cpp

Want to document this (that passing null for acqRow is allowed) in mdb.h?  And
copy/paste the comment change to morkStore.h, and maybe right here for good
measure?

>Index: toolkit/components/history/src/nsGlobalHistory.cpp
>@@ -3070,23 +3068,27 @@ nsGlobalHistory::FindRow(mdb_column aCol

And document that aResult can be null in both copies of nsGlobalHistory.h?

sr=bzbarsky with those nits.  Nice catch!
Attachment #185732 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 185732 [details] [diff] [review]
patch

requesting approval, this should help pageload time some
Attachment #185732 - Flags: approval1.8b3?
Comment on attachment 185732 [details] [diff] [review]
patch

a=chofmann
Attachment #185732 - Flags: approval1.8b3? → approval1.8b3+
This was checked in. Marking Fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: