297144 - avoid creating mork xpcom wrappers for link-visited check

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Brian Ryner (not reading)]

Currently, we force mork to create an nsIMdbRow object when checking to see if a
link is in history.  This is a waste since we can just use the row id to get the
same effect.  This also requires a small fix to mork to actually avoid creating
the object.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 185732 [details] [diff] [review]
patch

bz's on "vacation" and only has access to a win98 box, so this'll be a spotty
response.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 185732 [details] [diff] [review]
patch

>Index: db/mork/src/morkStore.cpp

Want to document this (that passing null for acqRow is allowed) in mdb.h?  And
copy/paste the comment change to morkStore.h, and maybe right here for good
measure?

>Index: toolkit/components/history/src/nsGlobalHistory.cpp
>@@ -3070,23 +3068,27 @@ nsGlobalHistory::FindRow(mdb_column aCol

And document that aResult can be null in both copies of nsGlobalHistory.h?

sr=bzbarsky with those nits.  Nice catch!

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 185732 [details] [diff] [review]
patch

requesting approval, this should help pageload time some

Comment 5

[chris hofmann]

Comment on attachment 185732 [details] [diff] [review]
patch

a=chofmann

Comment 6

[Caleb]

This was checked in. Marking Fixed.