Update Windows registry after software update

RESOLVED FIXED in mozilla1.8final

Status

()

Toolkit
Application Update
--
major
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Darin Fisher, Assigned: Darin Fisher)

Tracking

({fixed1.8})

unspecified
mozilla1.8final
x86
Windows XP
fixed1.8
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8b5 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [eta 7/27])

Attachments

(1 attachment, 1 obsolete attachment)

30.74 KB, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: approval1.8b4+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
Update Windows registry after software update

Installer builds of Firefox setup various registry keys that include the Firefox
version number.  We will need to update those keys after an update is applied to
Firefox.
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: blocking1.8b4?
Flags: blocking-aviary1.1?
Target Milestone: --- → Firefox1.1
Need this for b4.
Flags: blocking1.8b4?
Flags: blocking1.8b4+
Flags: blocking-aviary1.1?
(Assignee)

Updated

13 years ago
Depends on: 301521
(Assignee)

Comment 2

13 years ago
Created attachment 190483 [details] [diff] [review]
v1 patch

bsmedberg:

This is the code for updating the windows registry that we spoke about.  I
intend to extend this code to actually write an install-wizard.log file so that
the uninstaller will know how to clean up the registry keys created by this
code.  That will be done as part of the patch for bug 301253.

As we also discussed, I'm interested in simply doing away with the registry
setting code done by the uninstaller in favor of letting this code handle all
registry updating on windows.  There's also an XXX comment in the code about
copying the latest Uninstall$appname.exe into C:\WINDOWS.  I will add that once
I figure out how to package the Uninstall$appname.exe in the generated MAR
files ;-)
(Assignee)

Updated

13 years ago
Attachment #190483 - Flags: review?(benjamin)

Comment 3

13 years ago
Comment on attachment 190483 [details] [diff] [review]
v1 patch

This should not be a in a locale package... invent a new
chrome://branding/content/registryInfo.properties if you must.

Spelling nit: "heirarchy"

Otherwise it looks fine.
Attachment #190483 - Flags: review?(benjamin) → review-
(Assignee)

Comment 4

13 years ago
> This should not be a in a locale package... invent a new
> chrome://branding/content/registryInfo.properties if you must.

Ok.  What jar file should it go into then?

Updated

13 years ago
Whiteboard: [eta 7/27]
(Assignee)

Comment 6

13 years ago
Created attachment 190658 [details] [diff] [review]
v2 patch

Okay, this patch uses the branding content package.
Attachment #190483 - Attachment is obsolete: true
Attachment #190658 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #190658 - Flags: review?(benjamin)
Attachment #190658 - Flags: review+
Attachment #190658 - Flags: approval1.8b4+
(Assignee)

Comment 7

13 years ago
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Keywords: fixed1.8
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.