297147 - Update Windows registry after software update

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Darin Fisher]

Update Windows registry after software update

Installer builds of Firefox setup various registry keys that include the Firefox
version number.  We will need to update those keys after an update is applied to
Firefox.

Comment 1

[Mike Connor [:mconnor]]

Need this for b4.

Comment 2

[Darin Fisher]

Attachment: v1 patch

bsmedberg:

This is the code for updating the windows registry that we spoke about.  I
intend to extend this code to actually write an install-wizard.log file so that
the uninstaller will know how to clean up the registry keys created by this
code.  That will be done as part of the patch for bug 301253.

As we also discussed, I'm interested in simply doing away with the registry
setting code done by the uninstaller in favor of letting this code handle all
registry updating on windows.  There's also an XXX comment in the code about
copying the latest Uninstall$appname.exe into C:\WINDOWS.  I will add that once
I figure out how to package the Uninstall$appname.exe in the generated MAR
files ;-)

Comment 3

[Benjamin Smedberg]

Comment on attachment 190483 [details] [diff] [review]
v1 patch

This should not be a in a locale package... invent a new
chrome://branding/content/registryInfo.properties if you must.

Spelling nit: "heirarchy"

Otherwise it looks fine.

Comment 4

[Darin Fisher]

> This should not be a in a locale package... invent a new
> chrome://branding/content/registryInfo.properties if you must.

Ok.  What jar file should it go into then?

Comment 5

[Benjamin Smedberg]

http://lxr.mozilla.org/mozilla/source/other-licenses/branding/firefox/content/jar.mn
And the unbranded equivalent is
http://lxr.mozilla.org/mozilla/source/browser/base/jar.mn#47

Comment 6

[Darin Fisher]

Attachment: v2 patch

Okay, this patch uses the branding content package.

Comment 7

[Darin Fisher]

fixed-on-trunk