fix endian issues in asdecode

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: jaas, Assigned: jaas)

Tracking

Trunk
PowerPC
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
We are assuming big endian in asdecode, which isn't OK for Intel-based macs. A
patch was provided by Apple to fix the problem.
(Assignee)

Comment 1

13 years ago
Created attachment 185752 [details] [diff] [review]
Apple fix v1.0
Attachment #185752 - Flags: superreview?(sfraser_bugs)
Attachment #185752 - Flags: review+

Updated

13 years ago
Attachment #185752 - Flags: superreview?(sfraser_bugs) → superreview+
(Assignee)

Updated

13 years ago
Attachment #185752 - Flags: approval1.8b3?

Updated

13 years ago
Attachment #185752 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Comment 2

13 years ago
Checked in to trunk.

Checking in asdecode.cpp;
/cvsroot/mozilla/config/asdecode.cpp,v  <--  asdecode.cpp
new revision: 3.5; previous revision: 3.4
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Comment on attachment 185752 [details] [diff] [review]
Apple fix v1.0

>+    entry *swap = &entries[i];
>+    swap->id = OSSwapBigToHostInt32(swap->id);
>+    swap->offset = OSSwapBigToHostInt32(swap->offset);
>+    swap->length = OSSwapBigToHostInt32(swap->length);
>+	
>     entry& entry = entries[i];

No need for the |swap| variable; you can just use the existing |entry|
variable.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.