Closed
Bug 297171
Opened 20 years ago
Closed 19 years ago
When calling advanceSelectedTab with a missing 2nd parameter , it should wrap
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: boullet.marc, Assigned: mconnor)
Details
Attachments
(1 file)
|
754 bytes,
patch
|
mconnor
:
first-review-
|
Details | Diff | Splinter Review |
Patch to bug#295721 breaks some extensions which use advanceSelectedTab (AiO gestures, mini-T, etc). Adding an argument to advanceSelectedTab is OK as far as the old behaviour is maintained when the corresponding parameter is missing. In your patch, it is just the reverse since a missing aWrap will stop wrapping.
|
||
Updated•20 years ago
|
OS: Windows XP → All
|
Reporter | |
Comment 1•20 years ago
|
||
Though I don't like the patch (in my opinion, false and missing should act the same), here it is.
|
Assignee | |
Updated•20 years ago
|
Attachment #185770 -
Flags: first-review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #185770 -
Flags: first-review+ → first-review-
|
|
Assignee | |
Comment 2•19 years ago
|
||
This patch didn't land, so we already have effectively changed the API in 1.5. Rather than change it back again, I'm going to mark this WONTFIX.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•