297213 - Submit button appears without having anything to submit

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Vlad Dascalu]

editproducts.cgi?action=editgroupcontrols&product=TestProduct&classification=Unclassified

If there aren't any groups available in a product, then by visiting the URL
above I get a table header, no rows and a submit button. It's confusing since
there is no data to submit.

Comment 1

[Sunil Joshi [:sjoshi]]

But I have doubt in this:
We can remove the Submit button, but it will again look odd displaying just the header of the table.

My Suggestion: if there are no groups then its better not to even display the headers and we can display add group link.through which user can add groups.

Please assign this bug to me with the approach to be followed in this case.
Thanks

Comment 2

[Frédéric Buclin]

I agree that if there is no group, then both the table and the submit button should not be displayed. Adding a link to create a group is a good idea, assuming the user has the privileges to create one.

Sunil: feel free to attach a patch to this bug even if this bug is not assigned to you. We usually wait for a contributor to contribute something before assigning the bug to him, because we often have contributors who say they want to work on a bug but never start working on it for various reasons.

Comment 3

[Sunil Joshi [:sjoshi]]

Attachment: Patch

Comment 4

[Frédéric Buclin]

Comment on attachment 653173 [details] [diff] [review]
Patch

>+[% IF product.group_controls(1).size %]

This doesn't work. If none of the user groups is available for products, you still get the headers but with no groups listed.


>+[%ELSE%]

Please add spaces around "ELSE" -> [% ELSE %]


>+<p>No group exists.

This message is inaccurate. You should say that "No groups are available for products.", because system groups always exist but are not available for products.


>+    <a href="editgroups.cgi?action=add">Add Group</a>

Maybe "Create a new group", because you are not *adding* a group to this product yet. You must create it first.


>+  [%END%]
>+</p>
>+[%END%]

Also add spaces around "END" -> [% END %]

Comment 5

[Sunil Joshi [:sjoshi]]

Attachment: Re-Patch

Comment 6

[Frédéric Buclin]

Comment on attachment 661496 [details] [diff] [review]
Re-Patch

>+[% display_group=1 %]

Add whitespaces around "=", else 008filter.t complains. Also, it should be display_groups (plural).


>+  [% IF display_group AND ((!group.group.isactive AND group.bug_count) or group.group.is_active) %]

This can simply be written as:

  [% IF display_group AND (group.group.isactive OR group.bug_count) %]

Or even better:

  [% NEXT UNLESS group.group.isactive OR group.bug_count %]
  [% IF display_group %]


>+      [% display_group =0 %]

Also add a whitespace after "=". Moreover, the indentation is wrong (2 whitespaces for templates).


>+  [% IF !group.group.isactive AND group.bug_count %]

With the [% NEXT UNLESS ... %] check above, you can remove the 2nd part of the test.


>+  [% ELSIF group.group.is_active %]

With the [% NEXT UNLESS ... %] check above, this can simply be [% ELSE %]


>+  [% IF user.in_group('creategroups') %]
>+      <a href="editgroups.cgi?action=add">Create a new group</a>
>+  [% END %]

Wrong indentation.


>+[% ELSE %]
>   </table>
>   <br>
>   <input type=submit name="submit" value="submit">
>   <br>
> </form>
>+[% END %]

Wrong indentation.


Your patch is working fine. I will fix these comments on checkin.

Comment 7

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/admin/products/groupcontrol/edit.html.tmpl
Committed revision 8421.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified template/en/default/admin/products/groupcontrol/edit.html.tmpl
Committed revision 8415.