297236 - unable to dismiss about:config (Config Editor) window via keyboard

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect, P3)

Description

[sairuh (rarely reading bugmail)]

found using recent trunk tbird builds on any platform.

1. from Options/Preferences, go to Advanced | General
2. click the Config Editor button
3. dismiss the resulting about:config window via the keyboard: either Esc or
Ctrl/Cmd+W.

results: window doesn't go away. need to mouseclick the 'x' button (or red
button on Mac) in the titlebar to close the window.

Comment 1

[Mike Cowperthwaite]

Note that Alt+F4 does work, under Windows.

Comment 2

[Marco Zehe (:MarcoZ)]

Is this still the case in latest Trunk on the Mac? Is there no way to dismiss the window?

Comment 3

[Phil Ringnalda (:philor)]

It is: Windows, and Linux with a window manager that provides a shortcut for the X-to-close button, you have a workaround (though no more than a workaround), but OS X doesn't provide one. And since config.xul expects to be opened as about:config in a browser window, it doesn't provide any keybindings, so we need to overlay it with an Esc == window.close().

Comment 4

[Žiga Sancin]

Taking.

Comment 5

[Žiga Sancin]

Attachment: patch v1

Comment 6

[Phil Ringnalda (:philor)]

Comment on attachment 336661 [details] [diff] [review]
patch v1

Nice! I thought for a while about whether Esc *or* Cmd+W was actually the correct one for the sort of beast it is, but then I realized that since I couldn't figure it out offhand, both is better than the one true one.

Comment 7

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/76558fa9afbd

Comment 8

[Žiga Sancin]

Thanks Phil!

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080913035135 Shredder/3.0b1pre ID:20080913035135

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b1pre) Gecko/20080913070841 Shredder/3.0b1pre