297257 - Include reporter in suite

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

The overlay was apparently created with support for suite, so it may be as
simple as enabling the extension in the build and making sure the installer
grabs the right files.

Comment 1

[Robert Accettura [:raccettura]]

Yea, and allegedly people have built SeaMonkey with reporter enabled, and it
works for them.  I haven't personally, so I can't verify that.

I do know it works in SeaMonkey since I built an xpi and installed it myself.

Comment 2

[Robert Kaiser]

I didn't try to run it, but I've been building reporter in my personal SeaMonkey
builds for a while now without problems

Comment 3

[Ian Neal]

So someone just needs to spin a simple patch to switch it on for Suite builds then?

Comment 4

[Ian Neal]

Is it just a matter of adding reporter to the MOZ_EXTENSIONS_DEFAULT line for
suite in mozilla/configure.in ?
http://lxr.mozilla.org/mozilla/source/configure.in#3797

Comment 5

[Robert Kaiser]

(In reply to comment #4)
> Is it just a matter of adding reporter to the MOZ_EXTENSIONS_DEFAULT line for
> suite in mozilla/configure.in ?
> http://lxr.mozilla.org/mozilla/source/configure.in#3797

I think it is. There's actually one thing in reporter though, that might be
sub-optimal for us:
http://lxr.mozilla.org/mozilla/source/extensions/reporter/resources/content/reporter/reportWizard.js#355
calls all Mozilla Application Suite "SeaMonkey/1.x" internally, which might
clash with our future name being "SeaMonkey".
Robert, does anything speak against using "Mozilla/" or even "MozillaSuite/" in
that line so that you people can easier differentiate between those and our
"SeaMonkey/1.0a" that we should report after rebranding and fixing bug 294943?

Comment 6

[Robert Accettura [:raccettura]]

After you guys rebrand we can change.

I'm a little fussy on product names, but if you change your product name.  I
obviously expect it to change ;-).

I just don't want 10k different product names floating around in the DB.

Comment 7

[Robert Kaiser]

(In reply to comment #6)
> After you guys rebrand we can change.
> 
> I'm a little fussy on product names, but if you change your product name.  I
> obviously expect it to change ;-).
> 
> I just don't want 10k different product names floating around in the DB.

Sure, I can believe that :)
I just wanted to point out that you now might get SeaMonkey/1.8b2 identifiers
and then, for newer versions, you'll get SeaMonkey/1.0a (through nsIXULAppInfo,
I hope) and later SeaMonkey/1.0 - and that's _not_ Mozilla 1.0 suite, but what
would have got Mozilla 1.8 - and I guess having SeaMonkey/1.8b2 (or even
SeaMonkey/1.7.x) and those are older than SeaMonkey/1.0 might be confusing in
the DB as well...
It's you (or whoever works with the accumulated data) who has to deal with that,
though. I just thought it might help to produce less confusion.

Comment 8

[Robert Accettura [:raccettura]]

So I guess we'll run into a conflict when we hit 1.8 (again).

The best solution I think would be to just wait until rebranding is done.  At
that point enable it.

As for the handful of reports we already have.  I can purge/edit them.  There
not to many.

Comment 9

[Robert Kaiser]

(In reply to comment #8)
> So I guess we'll run into a conflict when we hit 1.8 (again).

At least then, yes (though I don't know if we have that exact version one time,
we'll see what the future brings).

> The best solution I think would be to just wait until rebranding is done.  At
> that point enable it.

Whatever you like. I just wanted to warn you before we're enabling reporter by
default in suite/SeaMonkey.

Comment 10

[Robert Kaiser]

Attachment: patch: turn on reporter in configure.in

I built SeaMonkey with this change (and reporter removed from my mozconfig),
and it builds reporter.jar, so it seems we really need just this line ;-)

Comment 11

[Ian Neal]

I am presuming that this will only be landed once the rebranding has completely
landed even if this gets r/sr/a before that?

Comment 12

[Robert Kaiser]

(In reply to comment #11)
> I am presuming that this will only be landed once the rebranding has completely
> landed even if this gets r/sr/a before that?

I don't think turning on reporter in nightlies has to depend on rebranding at
all. We should Just Do It (tm) :)

Comment 13

[Andrew Schultz]

You need to include reporter.jar (somewhere) in
mozilla/xpinstall/packager/packages-* to make it into the installer.

And we should probably make an optional component in the installer for this as
well.  I think in firefox, reporter can only be installed via the custom
installation.  We might want to also include it with the "complete" install.

Comment 14

[Andrew Schultz]

Attachment: add reporter to installer

Comment 15

[[e-mail]]

Comment on attachment 186010 [details] [diff] [review]
patch: turn on reporter in configure.in

I'd prefer if you got review from a build config peer.

Comment 16

[[e-mail]]

Comment on attachment 186470 [details] [diff] [review]
add reporter to installer

Are those - lines in the .pkg files correct? I'll give sr once someone who
understands them reviews and tests this first.

Comment 17

[[e-mail]]

Comment on attachment 186470 [details] [diff] [review]
add reporter to installer

Subsequent to ajschult's comments on IRC sr=me subject to bsmedberg approving
the .pkg changes.

Comment 18

[Benjamin Smedberg]

Comment on attachment 186470 [details] [diff] [review]
add reporter to installer

Damn it's a lot of work to update something so simple.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

There's a typo here, which exists for all /reporter.jst files:

+var err = initInstall("Webiste Reporter", "Reporter", "$Version$");

Comment 20

[chris hofmann]

Comment on attachment 186470 [details] [diff] [review]
add reporter to installer

a=chofmann

Comment 21

[Robert Kaiser]

checked in. This bug should be fixed, I hope :)

Comment 22

[Robert Accettura [:raccettura]]

If you guys do some testing, please point extensions.reporter.serviceURL to
http://reporter-dev.mozilla.org/service/

you'll need to clear your extensions.reporter.sysid before and after you make
that change.

Comment 23

[Serge Gautherie (:sgautherie)]

(In reply to comment #19)
> There's a typo here, which exists for all /reporter.jst files:
> 
> +var err = initInstall("Webiste Reporter", "Reporter", "$Version$");

Could someone add this nit fix ?
{{
-var err = initInstall("Webiste Reporter", "Reporter", "$Version$");
+var err = initInstall("Website Reporter", "Reporter", "$Version$");
}}

Comment 24

[Andrew Schultz]

> Could someone add this nit fix ?

The patch kairo committed already included that fix.

Comment 25

[Serge Gautherie (:sgautherie)]

(In reply to comment #24)
> > Could someone add this nit fix ?
> 
> The patch kairo committed already included that fix.

My mistake: I had only checked this bug&patch, and not the Trunk :-<

Comment 26

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050629 Windows XP Seamonkey trunk, now that bug 298675 is fixed...

Help -> Report Broken Web Site is in and functional.