297294 - Very choppy DHTML animation

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Hübner]

Running the DHTML examples shows a very choppy behaviour, tested on win-xp pro 
sp2, 2ghz, 1gb ram with trunk build 2005060906

Comment 1

[Boris Zbarsky [:bzbarsky]]

Someone needs to run this through jprof. I can't do that for another three weeks.

Comment 2

[Martijn Wargers (dead)]

Attachment: Testcase

This testcase is more or less the same as from the url, but I replaced the
images with divs.
With this I still get the choppy animation. But I don't get a high cpu (in
fact, it is almost zero). So my guess would be that it has got something to do
with the various timers that get fired.

Comment 3

[Markus Hübner]

Might Brendan's suggestion at https://bugzilla.mozilla.org/show_bug.cgi?
id=142969#c9 bring any improvement here?

Comment 4

[Marius Strumyla]

Running the URL and the testcase is very smooth for me with almost 0% CPU.
Using 20050609 trunk build on Win2k, 700Mhz, 512 RAM, Matrox Millenium G400

Comment 5

[Martijn Wargers (dead)]

Strange, I see the bug with a regular downloaded Firefox trunk build, but I
don't see the bug with my MingW non-debug build.
This is on WinXP, using 600MHz Duron, NVidia GeForce2MX 32 MB, 32 bit color depth.

Comment 6

[Martijn Wargers (dead)]

Oh wait, I have the "What I backed out" patch checked in from bug 280922 in that
MingW build (I forgot to rebuild layout/build when undoing that change).
So I think this has got something to do with bug 280922.

Comment 7

[Markus Hübner]

Updating URL.

Comment 8

[Markus Hübner]

Does this relate to bug 291386 ?

Comment 9

[Markus Hübner]

Running with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060411 Firefox/3.0a1 this is still terrible.
I do hope this will get a lot better when bug 326273 is in.

Comment 10

[Martijn Wargers (dead)]

Markus, the testcase is running much more smoothly for me now in the 2006-05-11 trunk build. I would call this fixed by bug 326273.
Could you please test with 2005-05-11 trunk build or later?

Comment 11

[Bryan]

I'm seeing the same sort of issue on the latest branch builds (don't know if it's a regression or just how it's always been, but it is "choppy").  Is there any love that can be given to the branch?

BUILD: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a2) Gecko/20060510 BonEcho/2.0a2 ID:2006051100

~B

Comment 12

[u88484]

Ryan: the nsIThreadManager stuff wasn't checked into the branch.

----

Works great for me now on latest trunk, I'd also say to mark this fixed.

Comment 13

[José Jeria]

With 2006-05-11 trunk build on XP this animation is now smoother in Mozilla than IE and Opera

Marking FIXED (bug 326273). Please reopen if  you don't agree.