297303 - signals returning boolean but not using accumulators

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

The "open_uri" and "dom_*" signals have return type boolean. Returning TRUE for
open_uri cancels the load, and returning TRUE for dom_* marks the event as
consumed. But the signals are created with gtk_signal_new, which makes it
impossible to specify a signal accumulator. This means that if you have more
than one signal handler connected, the signal emission does NOT stop on the
first TRUE return, but instead continues; and the signal return value is the
return value of the last handler.

The only way to fix this is to use g_signal_new instead of gtk_signal_new; that
means we will need to #ifdef MOZ_WIDGET_GTK2 a whole load of code.

Comment 1

[Oleg Romashin (:romaxa)]

(In reply to comment #0)
> The "open_uri" and "dom_*" signals have return type boolean. Returning TRUE for
> open_uri cancels the load, and returning TRUE for dom_* marks the event as
> consumed. But the signals are created with gtk_signal_new, which makes it
> impossible to specify a signal accumulator. This means that if you have more
> than one signal handler connected, the signal emission does NOT stop on the
> first TRUE return, but instead continues; and the signal return value is the
> return value of the last handler.
> 
> The only way to fix this is to use g_signal_new instead of gtk_signal_new; that
> means we will need to #ifdef MOZ_WIDGET_GTK2 a whole load of code.

Any patches from anybody for fixing this problem?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Embedding: GTK Widget isn't a thing, closing.