Closed Bug 297307 Opened 20 years ago Closed 20 years ago

Tools -> DOM Inspector opens empty; Ctrl+Shift+I works fine

Categories

(Firefox :: Menus, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: Peter6, Assigned: steffen.wilberg)

References

Details

(Keywords: regression)

Attachments

(1 file)

repro:

go to Menu -> Tools -> Dom Inspector   Ctrl+Shift+i
and press the link.

result :

Domi opens empty , the current url is not in the "inspect" bar

When Ctrl+Shift+i is pressed DomI opens with the current page
Selecting Tools->DOM Inspector should open up with the current URL content, just
as Shift-Ctrl-I does.
Confirming on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050608 Firefox/1.0+
how about a menu change to:

Tools
----
----
----
Dom Inspector > Inspect the current page (ctrl+shift+i) /(cmd+shift+i)
                Inspect Chrome
----
----

to keep everyone happy ?
Damn, I missed that in the review.  And this is actually a good thing for my
daily work since I don't use the page bits much, but its a UI change that we
shouldn't make, since its targeted as a web developer tool, primarily (chrome is
a neat bonus, but we want to be pushing this for web devs and this hinders that
too much).

http://lxr.mozilla.org/mozilla/source/extensions/inspector/resources/content/tasksOverlay-ff.xul#40
needs to changed to use Tasks:InspectPage.  I don't think this is expected, and
even so, the listed shortcut does it, so that's totally broken.

This is so not going the submenu route, I think we need a chromedev extension
that adds some extra bits to make it easier to debug chrome, but this shouldn't
be a default-ship option.  Its more of a "500 or so users might want this
option" deal.
*** Bug 296621 has been marked as a duplicate of this bug. ***
There's also a big grey blank area at the bottom of the DOM Inspector window
with a little caret ^ symbol, suggesting there's an XML error somewhere. 
(In reply to comment #6)
> There's also a big grey blank area at the bottom of the DOM Inspector window
> with a little caret ^ symbol, suggesting there's an XML error somewhere.
looks normal here (thin line) for both chrome/url inspection
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050613
Firefox/1.0+ ID:2005061308

I see the red arrow too, "Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.8b2) Gecko/20050613 Firefox/1.0+", standard build options.
Attached patch patchSplinter Review
As explained in comment 4.
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #186643 - Flags: review?(mconnor)
Keywords: regression
OS: Windows 2000 → All
Hardware: PC → All
Summary: Menu , Dom Inspector opens empty → Tools -> DOM Inspector opens empty; Ctrl+Shift+I works fine
Comment on attachment 186643 [details] [diff] [review]
patch

r+a=me
Attachment #186643 - Flags: review?(mconnor)
Attachment #186643 - Flags: review+
Attachment #186643 - Flags: approval-aviary1.1a2+
Checking in mozilla/extensions/inspector/resources/content/tasksOverlay-ff.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/tasksOverlay-ff.xul,v 
<--  tasksOverlay-ff.xul
new revision: 1.2; previous revision: 1.1
done

Regarding comments 6 and 8, I haven't seen this. Marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking-aviary1.1?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: