297318 - Firefox C++ Extension are incompatible between version 1.0, 1.1: entry point ?Clone@nsMemory@@SAPAXBXI@Z

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[mgueury]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

This is a continuation of problem 1 of bug 295950.

I am currently unable to make a version that works for Firefox 1.0
and 1.1.
If I enable 
- the maxversion in install.rdf to 1.0+ 
- with the C library 1.0
when the extension is loaded in Firefox 1.0+, it gives this error message
when loading firefox. Because the function nsMemory::clone is not anymore
in the xpcom.dll
  
XPCOM:EventReceiver The procedure entry point 
?Clone@nsMemory@@SAPAXBXI@Z could not be found in the dynamic 
library xpcom.dll

My main issue is that I do not use any nsMemory::clone function in my code.
The only mozilla functions I use in mozilla are string handling ones.
You can check the code here:

Instruction: http://users.skynet.be/mgueury/mozilla/compile.html
Source: http://users.skynet.be/mgueury/mozilla/mozilla_tidy_source.zip
CVS:
http://cvs.sourceforge.net/viewcvs.py/htmlvalidator/validator/mozilla/extensions/tidy/src

The only solution is to have 2 XPI files, one for 1.0 and one for 1.0+. (...)
What I currently do. It works.

But I think that the Mozilla libraries with which I link the DLL: 
- string (to get the UFT8 strings)
- xpcom (to be call my functions from JS)

uses the nsMemory internally.

The same problem happens also in the opposite direction. (After installing
the extension in 1.1. And then use the same profile with Firefox 1.0.)
But the error is about nsAlloc.


Reproducible: Always

Steps to Reproduce:
1. Download the XPI for Firefox 1.0. here
  http://users.skynet.be/mgueury/mozilla/download.html
2. unzip the xpi.
   change the maxversion to 1.1 in the install.rdf
3. rezip the xpi
4. install the XPI in Firefox 1.0
   restart it works
5. start firefox 1.1 -> error


Expected Results:  
No error

This is not critical as there is a WA. But if it happens between each version,
making extensions for Firefox in C++ is too difficult to maintain. As it need to be 
recompiled:
- for each platform
- for each version

-> the result is that I have currently 6 XPI for each version of my extension
   3 (Windows/Linux/MacOsX) * 2 (Firefox 1.0, Firefox 1.1) = 6 XPI

Thanks bya advance

Comment 1

[mgueury]

I suspect this this use the function internally too:

NS_IMPL_ISUPPORTS1_CI(nsTidyImpl, nsITidy)

Comment 2

[mgueury]

I will upload an extension compiled for Firefox 1.0
but with a bad maxversion 1.1 in install.rdf

The error message is happening only in previous version of Firefox 1.1.
In DeerPark, the only symptom is an error in the javascript console window.

Error: this.tidy has no properties
Source File: chrome://tidy/content/tidyUtil.js
Line: 93

Comment 3

[Robert Strong (they/them - no direct email)]

Some info regarding creating components for Mozilla... note the sections
regarding the use of unfrozen interfaces. If you did use an unfrozen interface
this bug is invalid.
"If you want to be protected against changes in the Gecko, you should only use
interfaces and API that are clearly marked FROZEN in their idl description."
http://www.mozilla.org/projects/embedding/faq.html

and

http://www.mozilla.org/projects/xpcom/book/cxc/html/weblock_finish.html

and I am sure elsewhere as well.

Comment 4

[Samuel Sidler (old account; do not CC)]

Is there any update for this bug? Were the interfaces you were using frozen? Is this bug fixed with Firefox 2.0.0.3?

Comment 5

[mgueury]

You can close this bug, it is fixed by using XPCOM_GLUE.

Thanks

Comment 6

[Samuel Sidler (old account; do not CC)]

Thanks for reporting back!