297365 - adding search term to a "full" saved search dialog scrolls term being edited out of view

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Asa Dotzler [:asa]]

If you have four or more terms in a saved search (such that the next one will
create a scrollbar) and you create one more somewhere in the middle of the list
using the "+" button, the list scrolls to the bottom even if the term you were
adding is up at the top. 

Steps:

1. create a saved search with four criteria and close the dialog.
2. open the saved search and click the "+" button next to the top search to
insert a new criteria box between the first and second items.

Results: the list is scrolled to the bottom
Expected: the list should not scroll.

The new criteria still has the focus highlight, but the list gets scrolled to
the end as if that's where the new term was supposed to be. This is especially
painful when you have a long list and you're adding terms in the middle of the list.

Comment 1

[Scott MacGregor]

Attachment: the fix

We used to always scroll to the last row after we add a new row to the search
dialog box.

The fix is to pass in rowNumber (the row whose add button was just pressed) + 1
to ensure that the next row (which is the one we just added) is scrolled into
view.

onMore gets called when the dialog first comes up to create the very first
search term row so I had to add an extra check for that condition:

scrollToLastSearchTerm(gTotalSearchTerms == 1 ? 0 : rowNumber + 1);

Comment 2

[Scott MacGregor]

this logic can be cleaned up a bit and the method name needs renamed to be more
clear. 

Comment 3

[Scott MacGregor]

Attachment: better fix

Comment 4

[Wayne Mery (:wsmwk)]

similar issue occurs no matter where add the new term, as long as term being modified is at the top or bottom of the dialog's view.

Comment 5

[Magnus Melin [:mkmelin]]

I don't see this on linux trunk...?

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to comment #5)
> I don't see this on linux trunk...?

Think I better understand comment 0, and I agree WFM.

However, please check my detective work ...
- attachment 186536 [details] [diff] [review], the "better fix", did not check in.
- attachment 186162 [details] [diff] [review], the first fix, checked in (1.41 scott 2005-06-14 16:20).  

Comment 7

[Magnus Melin [:mkmelin]]

Scott, do you still want the "better fix"? It should be ready for check-in.

Comment 8

[buovjaga]

(In reply to Asa Dotzler [:asa] from comment #0)
> Steps:
> 
> 1. create a saved search with four criteria and close the dialog.
> 2. open the saved search and click the "+" button next to the top search to
> insert a new criteria box between the first and second items.
> 
> Results: the list is scrolled to the bottom
> Expected: the list should not scroll.

It doesn't get scrolled anymore. WFM.

Thunderbird 52.0 (32-bit)
Windows 7 64-bit