Closed
Bug 29737
Opened 25 years ago
Closed 25 years ago
selection slow in large text files
Categories
(Core :: DOM: Selection, defect, P3)
Core
DOM: Selection
Tracking
()
VERIFIED
FIXED
M14
People
(Reporter: mozeditor, Assigned: sfraser_bugs)
Details
(Keywords: perf, Whiteboard: [PDT+] w/b minus by 03/03 fix awaiting approval)
Per our performance work in 28783, I've noticed that if we paste in a 2000 line text file into composer, it then becomes very hard to drag select anything in it, and selection becomes very slow. I suspect this is the same GetPrimaryFrameFor() performance bug that Simon seperately filed, but I'm adding this bug just in case it isn't.
Reporter | ||
Comment 1•25 years ago
|
||
adding perf to keywords adding beta1 to keywords just in case mike or anyone else finds some low lying fruit
Assignee | ||
Comment 2•25 years ago
|
||
It is interesting here to compare the selection speed with the same file in the browser window. If there is a big difference, then the slowdown in composer is probably related to my UI updating code.
Updated•25 years ago
|
Target Milestone: M14
I just verified that this is being caused by nsInterfaceState::NotifySelectionChanged(). If I add some code to return early from that method, selection seems much faster.
status is down to 30 sec for large pastes. still lookin at more. see bug 28783
Status: NEW → ASSIGNED
Putting on PDT+ radar for beta1. But will make PDT- and release note if not fixed by 03/03
Whiteboard: [PDT+] w/b minus by 03/03
Assignee | ||
Comment 6•25 years ago
|
||
We need to update the composer toolbar on a timer. I'll do this now.
Assignee: mjudge → sfraser
Status: ASSIGNED → NEW
Assignee | ||
Comment 7•25 years ago
|
||
Have reviwed fix in hand, awaiting approval.
Status: NEW → ASSIGNED
Whiteboard: [PDT+] w/b minus by 03/03 → [PDT+] w/b minus by 03/03 fix awaiting approval
Assignee | ||
Comment 8•25 years ago
|
||
Fix checked in. This should make selection faster. Note that you may still get the odd halting delay with large selections, which is bug 30185
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 9•25 years ago
|
||
I'm rubber-stamping this as verified. Moderately sized selections in a 204K text file (macfixit.com copied 20 times as plain text) doesn't feel unreasonable on a 266 Mhz G3, using the 2000030508 Mac OS build. It remains slow to: * Select a large block of text * Scroll elsewhere on the page * Select another block of text (Specifically, a several second pause will take place before you can select the second text block.) --- Joe, please feel free to double-check this one, as this bug report lacks specific timing information and a specific test case, so I can't meaningfully verify this bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•