297374 - missing this. in nsHelperAppDlg.js

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Error: _timer is not defined
Source File: file:///home/chb/builds/opt-trunk/dist/bin/components/nsHelperAppDlg.js
Line: 403

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[[e-mail]]

Comment on attachment 185904 [details] [diff] [review]
patch

Don't forget to patch both branch and trunk. (As if you would forget!)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 185904 [details] [diff] [review]
patch

makes bug 283103's patch work as intended. low risk - just references the right
variable

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

(oh, meant to mention that this patch does not apply to the aviary branch. the
patch that caused this wasn't landed there, and firefox does not use this file.)

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk
Checking in embedding/components/ui/helperAppDlg/nsHelperAppDlg.js;
/cvsroot/mozilla/embedding/components/ui/helperAppDlg/nsHelperAppDlg.js,v  <-- 
nsHelperAppDlg.js
new revision: 1.68; previous revision: 1.67
done

I think this should block 1.7.9, this error clutters up the JS console.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 185904 [details] [diff] [review]
patch

a=dveditz

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on MOZILLA_1_7_BRANCH:

Checking in embedding/components/ui/helperAppDlg/nsHelperAppDlg.js;
/cvsroot/mozilla/embedding/components/ui/helperAppDlg/nsHelperAppDlg.js,v  <-- 
nsHelperAppDlg.js
new revision: 1.55.2.4; previous revision: 1.55.2.3
done