javascript strict warning in aboutDialog.js

RESOLVED FIXED

Status

()

Firefox
General
--
trivial
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: florian, Assigned: Romain BEZUT)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

823 bytes, patch
mconnor
: review+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
[Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.8) Gecko/20050511
Firefox/1.0.4]

Avertissement : assignment to undeclared variable gSelectedPage
Fichier Source : chrome://browser/content/aboutDialog.js
Ligne : 11

Also reproduced in:
[Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050610
Firefox/1.0+]
(Assignee)

Comment 1

13 years ago
Created attachment 185935 [details] [diff] [review]
patch
Attachment #185935 - Flags: review?(mconnor)
(Assignee)

Comment 2

13 years ago
Comment on attachment 185935 [details] [diff] [review]
patch

Index: base/content/aboutDialog.js
===================================================================
RCS file: /cvsroot/mozilla/browser/base/content/aboutDialog.js,v
retrieving revision 1.5
diff -u -r1.5 aboutDialog.js
--- base/content/aboutDialog.js 30 Nov 2004 08:22:43 -0000	1.5
+++ base/content/aboutDialog.js 11 Jun 2005 12:03:39 -0000
@@ -34,6 +34,8 @@
 #
 # ***** END LICENSE BLOCK ***** -->

+var gSelectedPage = 0;
+
 function init(aEvent) 
 {
   if (aEvent.target != document)
@@ -43,7 +45,6 @@

   var button = document.documentElement.getButton("extra2");
   button.setAttribute("label",
document.documentElement.getAttribute("creditslabel"));
-  gSelectedPage = 0;
   button.addEventListener("command", switchPage, false);

   document.documentElement.getButton("accept").focus();
(Assignee)

Updated

13 years ago
Attachment #185935 - Attachment is obsolete: true
(Assignee)

Comment 3

13 years ago
Created attachment 185941 [details] [diff] [review]
patch

This new patch should fix a problem about credits page which was not reachable
with the last one ...
Attachment #185941 - Flags: review?(mconnor)
(Assignee)

Updated

13 years ago
Attachment #185935 - Flags: review?(mconnor)

Updated

13 years ago
Attachment #185941 - Flags: review?(mconnor) → review+
(Assignee)

Updated

13 years ago
Attachment #185941 - Flags: approval-aviary1.1a2?

Updated

13 years ago
Attachment #185941 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Whiteboard: [checkin needed]
fix checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Reporter)

Updated

13 years ago
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.