Closed
Bug 297406
Opened 19 years ago
Closed 19 years ago
javascript strict warning in aboutDialog.js
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: florian, Assigned: romain)
Details
Attachments
(1 file, 1 obsolete file)
823 bytes,
patch
|
mconnor
:
review+
asa
:
approval-aviary1.1a2+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.8) Gecko/20050511 Firefox/1.0.4] Avertissement : assignment to undeclared variable gSelectedPage Fichier Source : chrome://browser/content/aboutDialog.js Ligne : 11 Also reproduced in: [Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050610 Firefox/1.0+]
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #185935 -
Flags: review?(mconnor)
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 185935 [details] [diff] [review] patch Index: base/content/aboutDialog.js =================================================================== RCS file: /cvsroot/mozilla/browser/base/content/aboutDialog.js,v retrieving revision 1.5 diff -u -r1.5 aboutDialog.js --- base/content/aboutDialog.js 30 Nov 2004 08:22:43 -0000 1.5 +++ base/content/aboutDialog.js 11 Jun 2005 12:03:39 -0000 @@ -34,6 +34,8 @@ # # ***** END LICENSE BLOCK ***** --> +var gSelectedPage = 0; + function init(aEvent) { if (aEvent.target != document) @@ -43,7 +45,6 @@ var button = document.documentElement.getButton("extra2"); button.setAttribute("label", document.documentElement.getAttribute("creditslabel")); - gSelectedPage = 0; button.addEventListener("command", switchPage, false); document.documentElement.getButton("accept").focus();
Assignee | ||
Updated•19 years ago
|
Attachment #185935 -
Attachment is obsolete: true
Assignee | ||
Comment 3•19 years ago
|
||
This new patch should fix a problem about credits page which was not reachable with the last one ...
Attachment #185941 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Attachment #185935 -
Flags: review?(mconnor)
Updated•19 years ago
|
Attachment #185941 -
Flags: review?(mconnor) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #185941 -
Flags: approval-aviary1.1a2?
Updated•19 years ago
|
Attachment #185941 -
Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Updated•19 years ago
|
Whiteboard: [checkin needed]
Comment 4•19 years ago
|
||
fix checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•19 years ago
|
Whiteboard: [checkin needed]
You need to log in
before you can comment on or make changes to this bug.
Description
•