297410 - Update button does nothing in Sunbird extension manager

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Thorsten 'nightrat' Fritz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

You can't update xtensions in Sunbird trunk builds. You click on the update
button but nothing happens.

Reproducible: Always

Steps to Reproduce:
1.Install an extension
2.click on update


Actual Results:  
Nothing happens.

Expected Results:  
Sunbird should show a dialog and check for updates.

Comment 1

[Robin Edrenius]

Confirming on
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050807 Mozilla
Sunbird/0.2+

The extension stays at "Looking for updates to <extensionname>" forever.
I have tried with Journal and Calendarhelp, same result.

This is vad the javascript console says:
Datasource: Update Started
Datasource: Addon Update Started: {cf926b9a-426a-83b1-9956-90c1823fddf6}
Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIPrefBranch2.getComplexValue]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/DOCUME~1/ROBINE~1/Desktop/nyy/SUNBIR~1.WIN/sunbird/components/nsExtensionManager.js
:: anonymous :: line 5163"  data: no]
Source File:
file:///C:/DOCUME~1/ROBINE~1/Desktop/nyy/SUNBIR~1.WIN/sunbird/components/nsExtensionManager.js
Line: 5163
Error: uncaught exception: [Exception... "Component returned failure code:
0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch2.getComplexValue]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/DOCUME~1/ROBINE~1/Desktop/nyy/SUNBIR~1.WIN/sunbird/components/nsExtensionManager.js
:: anonymous :: line 5163"  data: no]

Comment 2

[Joey Minta]

Attachment: define "extensions.update.url"

No one ever defined "extensions.update.url" as a preference in sunbird.js. 
This patch defines it.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 192204 [details] [diff] [review]
define "extensions.update.url"

r=mvl

Comment 4

[Joey Minta]

Patch checked in.