297478 - Minimo does not handle non-latin1 characters correctly

Status: RESOLVED WONTFIX

(Minimo Graveyard :: Minimo Front-End, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

- mozilla_get_attribute destroys non-latin1 characters (due to the use of
ToNewCString with a unicode argument, which essentially is an
AssignWithConversion in disguise). It also does not allow getting attributes
with names outside of latin1, although that's probably less of a concern.

- the two callers of this function:
http://lxr.mozilla.org/seamonkey/source/embedding/minimo/app/mozilla_api.cpp#340
http://lxr.mozilla.org/seamonkey/source/embedding/minimo/app/mozilla_api.cpp#384

apparently do some roundtrip through a wide string (??) and eventually pass the
result to necko, which expects a UTF-8 string, not a latin1 one.

- non-latin1 filenames are also not handled well:
http://lxr.mozilla.org/seamonkey/source/embedding/minimo/app/mozilla_api.cpp#203
http://lxr.mozilla.org/seamonkey/source/embedding/minimo/app/mozilla_api.cpp#232

I'm not sure what Gtk uses as filename encoding, but this code should probably
either use NS_NewNativeLocalFile, or treat the filenames as UTF-8 and convert to
UTF-16 strings using an appropriate conversion function.

Comment 1

[Doug Turner (:dougt)]

embedding/minimo/app/ is deprecated