297530 - calIItemBase.icalString returns properties that were never set

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

when calling .icalString on a todo or event, the string has properies that were
never set, but now have some default value, or a libical error.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: xpcshell testcase

Actual restults from the testcase: (also note that summary:foo shows up twice)
BEGIN:VCALENDAR
PRODID:-//Mozilla Calendar//NONSGML Sunbird//EN
VERSION:2.0
BEGIN:VTODO
SUMMARY:Foo
X-MOZILLA-GENERATION:undefined
PERCENT-COMPLETE:0
LAST-MODIFIED:ERROR: No Value
DTSTAMP:ERROR: No Value
SUMMARY:Foo
CREATED:ERROR: No Value
END:VTODO
END:VCALENDAR

expected:
BEGIN:VCALENDAR
PRODID:-//Mozilla Calendar//NONSGML Sunbird//EN
VERSION:2.0
BEGIN:VTODO
SUMMARY:Foo
LAST-MODIFIED:<some valid datetime>
DTSTAMP:<some valid datetime>
END:VTODO
END:VCALENDAR

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The ICS serializer needs to be updated to either check item.isPropertyPromoted()
on the property name before outputting from the property bag (because right now
it's getting the summary via item.title, and is also seeing a "SUMMARY"
property, for example), or to not use item.title and do everything through
properties.

That's at least one part of the problem; the last modified and other bits I'll
look at tomorrow.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch for date issue (checked in)

pavlov gave r+ on irc.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: more fixes (checked in)

This makes most serialization work again. It still outputs a percent-complete
and a mozilla-generation while those were never set.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 186087 [details] [diff] [review]
more fixes (checked in)

Please ignore the dump() statement I added.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 186087 [details] [diff] [review]
more fixes (checked in)

r=me without the dump() (or at least commented out)

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: check if percentageComplete and generation are really set

This patch checks if percentageComplete and generation are really set before
serializing them, so they don't show up when not set.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

last patch checked in. I think this bug is now fixed.