Closed
Bug 297553
Opened 20 years ago
Closed 12 years ago
Enable serverpush for Opera clients
Categories
(Bugzilla :: Query/Bug List, enhancement)
Bugzilla
Query/Bug List
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: ian, Assigned: selsky)
Details
Attachments
(1 file)
|
814 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
We should add Opera to the list of browsers that accept serverpush:
119 my $serverpush =
120 $format->{'extension'} eq "html"
121 && exists $ENV{'HTTP_USER_AGENT'}
122 && $ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/
123 && $ENV{'HTTP_USER_AGENT'} !~ /[Cc]ompatible/
124 && $ENV{'HTTP_USER_AGENT'} !~ /WebKit/
125 && !defined($cgi->param('serverpush'))
126 || $cgi->param('serverpush');
Maybe by changing this line:
122 && $ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/
...to:
122 && ($ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/ or
$ENV{'HTTP_USER_AGENT'} =~ /Opera/)
|
||
Updated•16 years ago
|
Severity: normal → enhancement
OS: Windows XP → All
Hardware: x86 → All
Whiteboard: [Good Intro Bug]
Target Milestone: --- → Bugzilla 3.6
|
|
||
Updated•15 years ago
|
Target Milestone: Bugzilla 3.6 → Bugzilla 3.8
|
||
Updated•14 years ago
|
Target Milestone: Bugzilla 4.0 → ---
|
Assignee | |
Comment 1•13 years ago
|
||
Patch enables serverpush for Opera clients, but leaves the "loading" spinner going.
Assignee: query-and-buglist → selsky
Status: NEW → ASSIGNED
Attachment #617367 -
Flags: review?(wicked)
Attachment #617367 -
Flags: review?(mkanat)
|
|
||
Updated•12 years ago
|
Attachment #617367 -
Flags: review?(wicked)
Attachment #617367 -
Flags: review?(mkanat)
Attachment #617367 -
Flags: review?(LpSolit)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 617367 [details] [diff] [review] Enable serverpush for Opera, v1 >+ && (($ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/) || ($ENV{'HTTP_USER_AGENT'} =~ /Opera/)) Nit: you don't need all these parens. The following should work fine: && ($ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/ || $ENV{'HTTP_USER_AGENT'} =~ /Opera/) Or even better: && $ENV{'HTTP_USER_AGENT'} =~ /(Mozilla.[3-9]|Opera)/ I will use this last form on checkin, which is more compact and readable. Anyway, r=LpSolit
Attachment #617367 -
Flags: review?(LpSolit) → review+
|
|
||
Updated•12 years ago
|
Flags: approval+
Whiteboard: [Good Intro Bug]
Target Milestone: --- → Bugzilla 4.4
|
|
||
Comment 3•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified buglist.cgi Committed revision 8254.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•