297567 - Attempts internet connection when browsing local resources

Status: RESOLVED FIXED

(Minimo Graveyard :: General, defect)

Description

[Clayton Williams]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: 

Minimo tries to launch an internet connection whenever a URI is loaded, even
when the URI points to content on the local machine. 

Reproducible: Always

Steps to Reproduce:
1. Start minimo. The default start page (resource://gre/res/start.html) will try
to initiate an internet connection if one isn't present. 
2.
3.

Comment 1

[Clayton Williams]

Attachment: patch for winEmbed.cpp that checks for common local resources

The patch just adds a check that parses a URI and looks for "resource:",
"file:", "localhost", and "127.0.0.1" and skips checking the internet
connection before loading those URIs.

Comment 2

[Clayton Williams]

Attachment: CORRECTED patch for winEmbed.cpp

Parses URIs for common local resources - "resource:", "file:", "localhost",
"127.0.0.1" - and skips the internet connection check for local content. The
first patch was created incorrectly.

Comment 3

[Clayton Williams]

This is really just a symptom of the larger problem, which is that MiniMo
doesn't use the pre-existing connection management code for Mozilla on windows,
such as the Autodialer. As a result, there is code written to handle switching
connections automatically, but it doesn't get called reliably. Most events that
need a connection don't call the connection switching code, and some events that
don't need a connection request one. I think this is a relatively simple problem
to fix, all the code needed to implement it is already written. I've written a
patch to move the code to where it should be and I have it working on my device.
I'm testing the patch now.

Comment 4

[Clayton Williams]

Attachment: Moves the connection choosing code out of winEmbed and enables the Autodialer

I tested this patch with the latest cvs update after I got that update to
build, and it seems to work. You will most likely encounter a problem with your
ARM libraries though, there is a comment error in rasdlg.h which never
presented itself before because the RAS code was completely commented out. Just
add a / to the beginning of the comment block and it will compile just fine.

Comment 5

[Doug Turner (:dougt)]

Attachment: Patch

cleaned up.  requires that you set a preference to enable this on Windows CE. 
Should be no change for default windows builds.

I haven't tested this; just compiled it.

Comment 6

[Darin Fisher]

Comment on attachment 187063 [details] [diff] [review]
Patch

aren't there changes needed to nsSocketTransport2.cpp to actually make this
code be used on WINCE?

Comment 7

[Doug Turner (:dougt)]

we were just going to use a preference to ensure that it was alway on for WinCE.

Comment 8

[Doug Turner (:dougt)]

Checking in base/src/Makefile.in;
/cvsroot/mozilla/netwerk/base/src/Makefile.in,v  <--  Makefile.in
new revision: 1.92; previous revision: 1.91
done
Checking in base/src/nsAutodialWin.cpp;
/cvsroot/mozilla/netwerk/base/src/nsAutodialWin.cpp,v  <--  nsAutodialWin.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in base/src/nsSocketTransport2.cpp;
/cvsroot/mozilla/netwerk/base/src/nsSocketTransport2.cpp,v  <-- 
nsSocketTransport2.cpp
new revision: 1.36; previous revision: 1.35
done

Marking as Fixed.