297593 - defaultpriority, defaultseverity, defaultplatform and defaultopsys parameters in editparams.cgi should be a dropdown menu

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Nina]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3

If you scroll through the parameters page (editparams.cgi) you get to item,
"defaultpriority:	This is the priority that newly entered bugs are set to."
beside it is a text field with the default value set to 'P2'. I've altered the
initial values for @priority in the localconfig file to be a different set of
values (not p1,p2,p3, etc..). The setting should be a dropdown menu so that
future Admins (not a person who set up the bugbase) can select a value from the
available set of default entries as supplied in the localConfig (which are
assumed to already be table entries by the time anyone is able to even GET to
this param page). This will avoid typos, guessing, making up something  that
doesn't exist, general 'idiot proofing', and ultimately a more elegant design.
IMO, the QA Manager/Bugzilla Administrator need not know cgi, perl, or anything
about the inner workings of the bugbase in order to use it. An acceptable
process should be that a network admin set up the initial bugbase and the
bugbase administrator (a QA manager most likely,) would be the person to set up
preferences on how they intent on getting the most usefulness out of their tool.

Reproducible: Always

Steps to Reproduce:
1. Install bugzilla
2. Install mySQL
3. run checksetup.pl (2x)
4. edit localConfig
5. run checkSetup.pl
6. Launch Bugzilla
7. go to the preferences page
8. scroll down to 'defaultpriority ' setting

Actual Results:  
A text field presents it self to enter the default bug priority and takes any
sting the user inputs

Expected Results:  
A drop down list of available values based on valid settings culled from the
config (or more accurately) mySQL (or dB flavor)

using versio 2.18 #stable

Comment 1

[Frédéric Buclin]

I agree. I got the same problem.

Comment 2

[Frédéric Buclin]

Before displaying a dropdown menu, we should forbid to delete the current
default priority. This point is considered in bug 298688.

Comment 3

[Frédéric Buclin]

Attachment: non-working patch

can someone tell me why

choices => ['', @::legal_opsys]

doesn't work ??

Comment 4

[Frédéric Buclin]

(In reply to comment #3)
> can someone tell me why
> 
> choices => ['', @::legal_opsys]
> 
> doesn't work ??

Converting defparams.pl into a .pm module fixes the problem (yes, I reached to
do it). mkanat, does it mean we should first remove defparams.pl in favor of a
Bugzilla/Config/Param.pm module? Or as justdave suggested, having one
Bugzilla/Config/*.pm per panel in editparams.cgi?

Comment 5

[Max Kanat-Alexander]

(In reply to comment #4)
> mkanat, does it mean we should first remove defparams.pl in favor of a
> Bugzilla/Config/Param.pm module? Or as justdave suggested, having one
> Bugzilla/Config/*.pm per panel in editparams.cgi? 

  Well, to be truly object-oriented, we'd need a Bugzilla::Config::Param object
anyway, even if we wanted to have subclasses of that object, so we should go
with Bugzilla::Config::Param as a package.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1

Comment 7

[Frédéric Buclin]

Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.31; previous revision: 1.30
done
Checking in Bugzilla/Config/BugFields.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugFields.pm,v  <--  BugFields.pm
new revision: 1.3; previous revision: 1.2
done