297619 - Build Thunderbird with gcc 4.0 on Mac

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Mentovai]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+

We need to be able to compile Thunderbird using gcc 4.0 on the Mac.  gcc 4.0 is
the default compiler in Xcode 2 shipping with Mac OS X 10.4.  This is the first
Thunderbird-specific step needed for MacOSX86 support.

Official Mozilla builds must continue using gcc 3.3.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Mark Mentovai]

Attachment: Cast in nsMsgAttachmentHandler.cpp for AppleDouble support

While compiling nsMsgAttachmentHandler.cpp with gcc 4.0/5026 from Xcode 2.1:
.../nsMsgAttachmentHandler.cpp: In member function 'nsresult
nsMsgAttachmentHandler::SnarfAttachment(nsMsgCompFields*)':
.../nsMsgAttachmentHandler.cpp:864: error: invalid conversion from 'const
char*' to 'char*'
.../nsMsgAttachmentHandler.cpp:864: error:   initializing argument 2 of 'int
ap_encode_init(appledouble_encode_object*, char*, char*)'

gcc 4.0 is more strict about type checking than its predecessors.  This patch
adds a (char *) cast.  The code in question is used for AppleDouble support and
is only built on Macs.

This is the only Thunderbird-specific change needed.

Comment 2

[Peter Van der Beken [:peterv]]

Wouldn't it be nicer to make ap_encode_init take a |const char*| ?

Comment 3

[Mark Mentovai]

Attachment: Conform types to const, no casting

peterv, you're right.  This is better, especially since ap_encode_init is only
ever called from nsMsgAttachmentHandler.cpp.

Comment 4

[Mark Mentovai]

Attachment: Retain const when calling into MoreFilesX

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 186260 [details] [diff] [review]
Retain const when calling into MoreFilesX

>Index: mozilla/mailnews/compose/src/nsMsgAppleDoubleEncode.cpp
>===================================================================

> int ap_encode_init( appledouble_encode_object *p_ap_encode_obj, 
>-	                  char                      *fname,
>+	            const char                *fname,

Remove the tab and line const up with appledouble.

Comment 6

[Mark Mentovai]

Attachment: Beautification

That pesky tab didn't show up in vi.

Comment 7

[Mark Mentovai]

Checked in 21:01 PDT