297625 - [Automatically] Decryption of Messages with Enigmail fails in Nightlies

Status: RESOLVED INVALID

(MailNews Core :: Security, defect)

Description

[Tobias Fischer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050611 Mnenhy/0.7.2.10002
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050611 Mnenhy/0.7.2.10002

Both automatically and manual Decryption of cryptet and/or signed Messages fails
in Nightlies. Last known good was 2005061120, first tested broken Build is
2005061206. 
Have tested with GnuPG 1.4.1 and Enigmail Nightly 20050613. 

Crypted Messages are still encrypted, no atumatically Passphrase comes up,
manuall decryption fails too.


Reproducible: Always

Steps to Reproduce:
1. Get actuall Nightly-Build from Trunk
2. Install Enigmail-Nightly
3. Mark encrypted or signed Message in MailNews

Actual Results:  
The Passphrase wont come up. Manuall decryption shows Passphrase, but Message
ist still encrypted. 

Expected Results:  
Passphrase comes up automatically when marking encrypted Message, and Message
will be decrypted. 

Only Checkin this timeframe comes frim biesi for Bug 241739
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-06-11+19%3A00%3A00&maxdate=2005-06-12+06%3A00%3A00&cvsroot=%2Fcvsroot

Possible Regression from Checkin for Bug 241739

Comment 1

[Tobias Fischer]

Add Keyword regression and CC biesi because of the possible regression from Bug
241739

Comment 2

[Tobias Fischer]

While starting 2005061306 JavaScript-Console throws:

Error: missing { before catch block
Source File: chrome://enigmail/content/enigmailMsgHdrViewOverlay.js
Line: 109, Column: 14
Source Code:
    catch (ex)�{}



And when I try to decrypt Message manually:

Error: enigUpdateHdrIcons is not defined
Source File: chrome://enigmail/content/enigmailMessengerOverlay.js
Line: 781

=  enigUpdateHdrIcons(exitCode, statusFlags, keyIdObj.value, userIdObj.value,
sigDetailsObj.value, errorMsg);

Comment 3

[Frank Wein [:mcsmurf]]

And who says this isn't a Enigmail bug :)?

Comment 4

[Tobias Fischer]

(In reply to comment #3)
> And who says this isn't a Enigmail bug :)?

Uah Frank, sure I don't know if this one is an Mozilla or Enigmail Bug, but I am
not an programmer. And it is allready an Bug for sure. If this is for Enigmail
-- sorry about that and feel free to close this as =invalid. ;)

I would like to file one for Enigmail than. 

Comment 5

[Karsten Düsterloh]

(In reply to comment #2)
> While starting 2005061306 JavaScript-Console throws:

While the error message as such seems to indicate an Enigmail bug,
 
> Error: missing { before catch block
> Source File: chrome://enigmail/content/enigmailMsgHdrViewOverlay.js
> Line: 109, Column: 14
> Source Code:
>     catch (ex)�{}

this line simply doesn't make sense from a programming pov, so I doubt it's
found in Enigmail. Tobias, which Enigmail version are you using? If you click on
the error link in the JavaScript Console, how does the code look there?

The last line above is actually the same as
>     catch (ex)�{}
and that � may be a sign of failed Unicode conversion and may well be a fallout
of bug 241739...

Comment 6

[Karsten Düsterloh]

> >     catch (ex)�{}

Bah, the � should be a Unicode 'unknown character' character, but
Bugzilla seems to kill that...
 
> this line simply doesn't make sense from a programming pov, so I doubt it's
> found in Enigmail. Tobias, which Enigmail version are you using?

FWIW, I downloaded the Mozilla Windows nightly 2005-06-14 of Enigmail and that
source file does not contain the Unicode 'unknown character' character...

And we had a similar problem with the stream reader some while ago...

Comment 7

[Patrick Brunschwig]

There is ideed a special character on that line in the source code which
shouldn't be there.

I have checked in a fixed version which should be available in tomorrow's
nightly build of Enigmail.

Could someone please close the bug? I have no rights to do this.

Comment 8

[Tobias Fischer]

Well, currently I am running Enigmail 0.92.0.0 Nightly-Build 20050613. I will
have a straight look at tomorrows Build, Patrick.

Thanks at all for your work, I will file the next Bug for Enigmail. ;-)
Close this one as Resolved=Invalid for now.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

>Bah, the � should be a Unicode 'unknown character' character, but
>Bugzilla seems to kill that...

when posting non-ASCII characters, you should set the charset to UTF-8...