297648 - javascript strict warning in customizeToolbar.xul

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Romain BEZUT]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+

It happens when you move an item from a "Customize Toolbar" window, i found two
of them :
The first : open JavaScript Console then do a right click on a Toolbar,
customize... and try to move an item, it makes a JS strict warning (if they have
been enabled).

The second : open JavaScript Console then go to Help Menu, Help Contents, click
on the 5th icon in order to "customize" and try to move an item, it makes a JS
strict warning, located in an other file than above.

Reproducible: Always

Steps to Reproduce:
see details
Actual Results:  
A JS strict warning.

Expected Results:  
The JS strict warnings are corrected.

Comment 1

[Romain BEZUT]

Attachment: patch

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Please mark all javascript strict warning bugs as blocking bug 296661.

Comment 3

[Benjamin Smedberg]

Comment on attachment 186196 [details] [diff] [review]
patch

Whatever this gDraggingFromPalette variable was supposed to be is now dead.
Please remove it entirely and re-request review from mconnor.

Comment 4

[Romain BEZUT]

Attachment: patch v2

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 186461 [details] [diff] [review]
patch v2

please ignore the one in help, since that entire file is going away rsn.

Please fix all other instances of this, including calendar/mail/composer

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Final patch

Final patch includes fixes for calendar, composer, mail, and toolkit.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 196461 [details] [diff] [review]
Final patch

that'll do, not needed for branch, its just a warning

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/calendar/sunbird/base/content/customizeToolbar.xul; new revision: 1.3;
mozilla/composer/base/content/customizeToolbar.xul; new revision: 1.2;
mozilla/mail/base/content/customizeToolbar.xul; new revision: 1.10;
mozilla/toolkit/content/customizeToolbar.xul; new revision: 1.14;