297652 - Javascript strict warning in query.cgi when the format chosen is "advanced"

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Romain BEZUT]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050613 Firefox/1.0+

Go on https://bugzilla.mozilla.org/query.cgi?format=advanced, and see with the
JavaScript Console that there is that following strict warning :

Warning: assignment to undeclared variable milestone
Source File: https://bugzilla.mozilla.org/query.cgi?format=advanced
Line: 214

(JS strict warning have to be enabled)

Reproducible: Always

Steps to Reproduce:
1. Go on https://bugzilla.mozilla.org/query.cgi?format=advanced
2. Open the JS Console
3. Look that there is a strict warning (JS strict warning have to be enabled)
Actual Results:  
There is a JS strict warning.

Expected Results:  
The JS strict warning is corrected.

Comment 1

[Teemu Mannermaa (:wicked)]

Confirmed on bmo, v2.20 branch and trunk using Firefox with
javascript.options.strict preference enabled. Doesn't happen on IE, although I
don't know if there's a way to enable more strict JS on IE.

Comment 2

[François Gagné]

on bugzilla.mozilla.org upgraded to version 2.20 on Saturday, October 22nd, 2005.

The line number for this error is now 228 instead of 214.

Should this _bug_ be move to 'Other b.m.o issues'

Comment 3

[Florian Quèze [:florian]]

Attachment: patch

Comment 4

[Teemu Mannermaa (:wicked)]

Comment on attachment 206708 [details] [diff] [review]
patch

Simple fix that corrects JS syntax and fixes this problem.

Comment 5

[Frédéric Buclin]

tip:

Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v  <--  form.html.tmpl
new revision: 1.35; previous revision: 1.34
done

2.20:

Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v  <--  form.html.tmpl
new revision: 1.32.2.1; previous revision: 1.32
done