When deleting a node in the dom inspector, I would expect that the next available node would be selected. Now, when I want to remove a whole row of nodes, I have to manually select afterwards I have deleted a node with the dom inspector.
Created attachment 186206 [details] [diff] [review] patch Well, this makes the dom inspector behave like I want it to.
Comment on attachment 186206 [details] [diff] [review] patch Looks reasonable! I won't be able to check in until July, but let me know if this still needs checkin at that point?
Attachment #186206 - Flags: approval1.8b3?
Attachment #186206 - Flags: approval1.8b3? → approval1.8b3+
Assignee: dom-inspector → martijn.martijn
Comment on attachment 186206 [details] [diff] [review] patch >+ var selectNode = this.nextSibling; >+ if (!selectNode) selectNode = node.previousSibling; >+ if (!selectNode) selectNode = this.parentNode; Nit: since JS's || operator works like Perl's, you can use e.g. node.nextSibling || node.previousSibling || node.parentNode
Created attachment 186535 [details] [diff] [review] patchv2 Thanks Neil. Does this patch need to go through the whole review process again?
Attachment #186206 - Attachment is obsolete: true
Neil, could you check patchv2 in? I don't think it needs to go to the whole review process again, does it? Thanks.
Sorry, somebody already checked in patch v1.
Ah, ok, thanks. I see that timeless checked it in. http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=dom.js&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=all&mindate=&maxdate=&cvsroot=%2Fcvsroot Ok, this is fixed then. That "node.nextSibling || node.previousSibling || node.parentNode" would be nice, but is not that important.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.