297677 - static builds need to explicitly reference libfoo.a, not rely on -L lib/components -lfoo

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Shaver (:shaver emeritus)]

There are a variety of ways to end up with libfoo.so in lib/components, even
when doing a static-app build, and if you're not in the list of blessed
platforms which currently get addprefix love it's easy to end up linking against
the wrong version.  In the _best_ case, you get a link failure.  It's probably
also possible to end up with a binary that isn't as static as you'd like.

I propose to make us use explicit filenames for the rest of the platforms as well.

(Blocking 295659 is a bit of a stretch, but close  enough.)

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: the obvious, trivial patch

mvl: want to see if this lets you build the XPI first in the calendar sequence,
again?

Comment 2

[Mike Shaver (:shaver emeritus)]

So this isn't enough, because we still have the wrong sort of object files
around when we're making the static lib (or the shared lib, I guess).

(We could force PIC for the stuff that _might_ be extension-used, but that would
defeat some of the purpose of a static build in the first place.)

Benjamin: do you think we should land this anyway?

Comment 3

[Benjamin Smedberg]

> Benjamin: do you think we should land this anyway?

I don't think anybody except calendar needs it, but I'm fine with landing it
as-is if it would make your life easier. Your call.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

With this patch, i can build a static sunbird build on linux, even if the build
still attempts to build a calendar.xpi. (no idea if the xpi works though)

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 186318 [details] [diff] [review]
the obvious, trivial patch

Yeah, we need this.

Comment 6

[Mike Shaver (:shaver emeritus)]

FIXED.