Closed Bug 297678 Opened 19 years ago Closed 19 years ago

Non-ascii feed names are garbled when they are imported from OPML file

Categories

(MailNews Core :: Feed Reader, defect)

Product:
MailNews Core
Component:
Feed Reader
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: u115577, Assigned: mscott)

Details

Attachments

(1 file, 1 obsolete file)

read in opml file as raw bytes, so the XML parser can detect the encoding
2.21 KB, patch
mscott
: review+
Details | Diff | Splinter Review 
If OPML file includes non-ascii feed names (e.g. Japanese), they are garbled.
Attached patch patch (obsolete) — — Splinter Review 

    
  

        Attachment #186220 -
        Flags: review?(mscott)

    
    

    
  
(typo in summary)
Summary: Non-ascii feed names are garbled when they are inported from OPML file → Non-ascii feed names are garbled when they are imported from OPML file

    
  

        Attachment #186220 -
        Flags: superreview?(mscott)

        Attachment #186220 -
        Flags: review?(sayrer)

        Attachment #186220 -
        Flags: review?(mscott)

    
    

    
  
Scott: I don't think I have the bugzilla permissions to review stuff. I'm -1 on
this though. The right way to fix it is to patch the way we read in the file.
I'll have something shortly.

    
    

    
  
Comment on attachment 186241 [details] [diff] [review]
read in opml file as raw bytes, so the XML parser can detect the encoding

Thanks Robert. I knew there was a good reason why I asked you to review that
patch :)

        Attachment #186241 -
        Flags: review?(mscott) → review+

    
  

        Attachment #186220 -
        Attachment is obsolete: true

        Attachment #186220 -
        Flags: superreview?(mscott)

        Attachment #186220 -
        Flags: review?(sayrer)

    
    

    
  
fix checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird1.1

    
    

    
  
Kohei, can you try a nightly build tomorrow and verify that this fix works for
you? Make sure the build date says 06/15 on it. Thanks!

    
    

    
  
I just tested 2005-06-15-05-trunk. Looks good for me. Thanks!

    
    

    
  
great. thanks for testing and for finding this bug.

    
  
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird1.1 → ---

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: