Closed Bug 297724 Opened 20 years ago Closed 20 years ago

rating stars code different, and wrong, everywhere

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: csthomas, Assigned: csthomas)

Details

(Whiteboard: [landme])

Attachments

(1 file)

I'm not sure if previously the code rounded the average to one decimal place
instead of 2, but with some patches that will land soon, stars don't work
entirely right.
Attached patch fix roundingSplinter Review
The moreinfo page for themes rounds to the nearest star (rather than 0.1 stars)
so I didn't change it.
Assignee: Bugzilla-alanjstrBugs → cst
Status: NEW → ASSIGNED
Attachment #186273 - Flags: first-review?(colin.ogilvie)
Attachment #186273 - Flags: first-review?(colin.ogilvie) → first-review+
Whiteboard: [landme]
Fixed

Checking in extensions/moreinfo.php;
/cvsroot/mozilla/webtools/update/extensions/moreinfo.php,v  <--  moreinfo.php
new revision: 1.26.2.15; previous revision: 1.26.2.14
done
Checking in extensions/showlist.php;
/cvsroot/mozilla/webtools/update/extensions/showlist.php,v  <--  showlist.php
new revision: 1.14.2.11; previous revision: 1.14.2.10
done
Checking in themes/showlist.php;
/cvsroot/mozilla/webtools/update/themes/showlist.php,v  <--  showlist.php
new revision: 1.12.2.12; previous revision: 1.12.2.11
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Also checked in the fix to themes/moreinfo.php which was missed in this patch.

Checking in themes/moreinfo.php;
/cvsroot/mozilla/webtools/update/themes/moreinfo.php,v  <--  moreinfo.php
new revision: 1.22.2.15; previous revision: 1.22.2.14
done

r=CTho on IRC yesterday.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: