Closed Bug 297792 Opened 19 years ago Closed 19 years ago

JavaScript strict warning in reportWizard.js

Categories

(Other Applications Graveyard :: Reporter, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: romain, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+

When I go on "Report Broken Web Site" under the "Help" menu, I get the following
javascript strict warning :

Warning: function getBuildConfig does not always return a value
Source File: chrome://reporter/content/reportWizard.js
Line: 299, Column: 10
Source Code:
    return;

(If you want to see this warning, "Strict warnings" have to be enabled)

Reproducible: Always

Steps to Reproduce:
1. Go on "Help", then go on "Report Broken Web Site"
2. See in the JavaScript Console the warning above
Version: unspecified → Trunk
Blocks: 296661
confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050614
Firefox/1.0+
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Attached patch patch (obsolete) — Splinter Review
Robert, is it ok that we return an empty string when the build config is not
available?
Assignee: robert → hskupin
Status: NEW → ASSIGNED
Comment on attachment 186402 [details] [diff] [review]
patch

Yea, go for it.

The server will likely bark in the unlikely sinareo, but I can tweak the server
to ignore it should that happen.
Attachment #186402 - Flags: review+
Actually...

Lets make it return "Unknown".

With that change r=robert@accettura.com
Attached patch patch v2Splinter Review
Take over r+ from comment 4.
Attachment #186402 - Attachment is obsolete: true
Attachment #186444 - Flags: review+
Attachment #186402 - Flags: review+
Attachment #186444 - Flags: approval1.8b3?
Attachment #186444 - Flags: approval1.8b3? → approval1.8b3+
Whiteboard: [checkin needed][a+]
Checking in extensions/reporter/resources/content/reporter/reportWizard.js;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.js,v
 <--  reportWizard.js
new revision: 1.21; previous revision: 1.20
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed][a+]
v
Status: RESOLVED → VERIFIED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: